fix: account for base when suggesting rerun cmd (#992)

<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #905
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->
Add additional filter logic to check if an options entry was excluded by
the base, and filter it out of the suggested rerun flags, add new test,
update failing test with suggestion from jest

(>^u^)><(^u^)><(^u^<)

---------

Co-authored-by: Josh Goldberg <[email protected]>

Author: GV14982

src/create/createRerunSuggestion.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it } from "vitest";
 
+import { getExclusions } from "../shared/options/augmentOptionsWithExcludes.js";
 import { Options } from "../shared/types.js";
 import { createRerunSuggestion } from "./createRerunSuggestion.js";
 
@@ -93,4 +94,28 @@ describe("createRerunSuggestion", () => {
 			'"npx create-typescript-app --mode initialize --base everything --access public --author TestAuthor --description \\"Test description.\\" --directory . --email-github [email protected] --email-npm [email protected] --exclude-all-contributors true --exclude-compliance true --exclude-lint-jsdoc true --exclude-lint-json true --exclude-lint-knip true --exclude-lint-md true --exclude-lint-package-json true --exclude-lint-perfectionist true --exclude-lint-spelling true --keywords \\"abc def ghi jkl mno pqr\\" --mode initialize --owner TestOwner --repository test-repository --skip-github-api true --skip-install true --skip-removal true --title \\"Test Title\\""',
 		);
 	});
+
+	it("does not list all excludes when using common base", () => {
+		const common = createRerunSuggestion({
+			base: "common",
+			...getExclusions(options, "common"),
+			excludeLintKnip: undefined,
+		});
+
+		expect(common).toMatchInlineSnapshot(
+			'"npx create-typescript-app --mode undefined --base common"',
+		);
+	});
+
+	it("does not list all excludes when using minimum base", () => {
+		const minimum = createRerunSuggestion({
+			base: "minimum",
+			...getExclusions(options, "minimum"),
+			excludeLintKnip: undefined,
+		});
+
+		expect(minimum).toMatchInlineSnapshot(
+			'"npx create-typescript-app --mode undefined --base minimum"',
+		);
+	});
 });

src/create/createRerunSuggestion.ts

@@ -1,4 +1,8 @@
 import { allArgOptions } from "../shared/options/args.js";
+import {
+	ExclusionKey,
+	getExclusions,
+} from "../shared/options/augmentOptionsWithExcludes.js";
 import { Options } from "../shared/types.js";
 
 function getFirstMatchingArg(key: string) {
@@ -30,10 +34,16 @@ export function createRerunSuggestion(options: Partial<Options>): string {
 	};
 
 	const args = Object.entries(optionsNormalized)
+		// Sort so the base is first, then the rest are sorted alphabetically
 		.sort(([a], [b]) =>
 			a === "base" ? -1 : b === "base" ? 1 : a.localeCompare(b),
 		)
-		.filter(([, value]) => !!value)
+		// Filter out all entries that have a key in the excluded object or have a falsy value
+		.filter(
+			([key, value]) =>
+				getExclusions(options, optionsNormalized.base)[key as ExclusionKey] ==
+					undefined && !!value,
+		)
 		.map(([key, value]) => {
 			return `--${getFirstMatchingArg(key)} ${stringifyValue(value)}`;
 		})

src/shared/options/augmentOptionsWithExcludes.test.ts

@@ -125,6 +125,6 @@ describe("augmentOptionsWithExcludes", () => {
 
 		const actual = await augmentOptionsWithExcludes(options);
 
-		expect(actual).toBe(options);
+		expect(actual).toStrictEqual(options);
 	});
 });

src/shared/options/augmentOptionsWithExcludes.ts

@@ -10,7 +10,7 @@ interface ExclusionDescription {
 	uncommon?: true;
 }
 
-type ExclusionKey = keyof Options & `exclude${string}`;
+export type ExclusionKey = keyof Options & `exclude${string}`;
 
 const exclusionDescriptions: Record<ExclusionKey, ExclusionDescription> = {
 	excludeAllContributors: {
@@ -119,6 +119,34 @@ const exclusionDescriptions: Record<ExclusionKey, ExclusionDescription> = {
 
 const exclusionKeys = Object.keys(exclusionDescriptions) as ExclusionKey[];
 
+export function getExclusions(
+	options: Partial<Options>,
+	base?: OptionsBase,
+): Partial<Options> {
+	switch (base) {
+		case "common":
+			return {
+				...Object.fromEntries(
+					exclusionKeys
+						.filter((exclusion) => exclusionDescriptions[exclusion].uncommon)
+						.map((exclusion) => [exclusion, options[exclusion] ?? true]),
+				),
+			};
+		case "minimum":
+			return {
+				...Object.fromEntries(
+					exclusionKeys.map((exclusion) => [
+						exclusion,
+						options[exclusion] ?? true,
+					]),
+				),
+			};
+		// We only really care about exclusions on the common and minimum bases
+		default:
+			return {};
+	}
+}
+
 export async function augmentOptionsWithExcludes(
 	options: Options,
 ): Promise<Options | undefined> {
@@ -172,31 +200,13 @@ export async function augmentOptionsWithExcludes(
 	switch (base) {
 		case undefined:
 			return undefined;
-
 		case "common":
-			return {
-				...options,
-				...Object.fromEntries(
-					exclusionKeys
-						.filter((exclusion) => exclusionDescriptions[exclusion].uncommon)
-						.map((exclusion) => [exclusion, options[exclusion] ?? true]),
-				),
-			};
-
-		case "everything":
-			return options;
-
 		case "minimum":
+		case "everything":
 			return {
 				...options,
-				...Object.fromEntries(
-					exclusionKeys.map((exclusion) => [
-						exclusion,
-						options[exclusion] ?? true,
-					]),
-				),
+				...getExclusions(options, base),
 			};
-
 		case "prompt":
 			const exclusionsNotEnabled = new Set(
 				filterPromptCancel(