Skip to content

Commit 973140d

Browse files
fix: remove redundant format at end of finalizeDependencies (#887)
## PR Checklist - [x] Addresses an existing open issue: fixes #748 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview 🔪. Also fixes a `lint --fix` command I found that was running after formatting. Lint rule auto-fixers might introduce formatting issues, so they should be run first.
1 parent 617dcc4 commit 973140d

File tree

3 files changed

+1
-9
lines changed

3 files changed

+1
-9
lines changed

src/create/createWithOptions.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ export async function createWithOptions({ github, options }: GitHubAndOptions) {
4141

4242
await runCommands("Cleaning up files", [
4343
"pnpm dedupe",
44-
"pnpm format --write",
4544
"pnpm lint --fix",
45+
"pnpm format --write",
4646
]);
4747

4848
const sendToGitHub =

src/steps/finalizeDependencies.test.ts

-6
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,6 @@ describe("finalize", () => {
6464
[
6565
"npx all-contributors-cli generate",
6666
],
67-
[
68-
"pnpm run format:write",
69-
],
7067
]
7168
`);
7269
});
@@ -94,9 +91,6 @@ describe("finalize", () => {
9491
[
9592
"pnpm add @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest eslint@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-jsdoc@latest eslint-plugin-n@latest eslint-plugin-regexp@latest husky@latest lint-staged@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest tsup@latest typescript@latest -D",
9693
],
97-
[
98-
"pnpm run format:write",
99-
],
10094
]
10195
`);
10296
});

src/steps/finalizeDependencies.ts

-2
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,4 @@ export async function finalizeDependencies(options: Options) {
7676
"-D",
7777
);
7878
}
79-
80-
await execaCommand("pnpm run format:write");
8179
}

0 commit comments

Comments
 (0)