Skip to content

Commit a944257

Browse files
chore: also mention GitHub apps in creation (#693)
## PR Checklist - [x] Addresses an existing open issue: fixes #692 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Skips using istanbul, in favor of v8. I'm hoping using the same coverage report format will help Codecov figure things out. Note that this now triggers vitest-dev/vitest#3605 issue of v8 counting types as untested.
1 parent be72601 commit a944257

6 files changed

+15
-170
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"@types/prettier": "^2.7.3",
6767
"@typescript-eslint/eslint-plugin": "^6.4.0",
6868
"@typescript-eslint/parser": "^6.4.0",
69-
"@vitest/coverage-istanbul": "^0.34.2",
69+
"@vitest/coverage-v8": "^0.34.2",
7070
"all-contributors-cli": "^6.26.1",
7171
"c8": "^8.0.1",
7272
"console-fail-test": "^0.2.3",

pnpm-lock.yaml

+12-165
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/steps/finalizeDependencies.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ describe("finalize", () => {
4444
expect(mockExecaCommand.mock.calls).toMatchInlineSnapshot(`
4545
[
4646
[
47-
"pnpm add @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest all-contributors-cli@latest cspell@latest eslint@latest eslint-config-prettier@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-import@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest npm-package-json-lint@latest npm-package-json-lint-config-default@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest sentences-per-line@latest should-semantic-release@latest tsup@latest typescript@latest yaml-eslint-parser@latest release-it@latest @vitest/coverage-istanbul@latest console-fail-test@latest eslint-plugin-no-only-tests@latest eslint-plugin-vitest@latest vitest@latest -D",
47+
"pnpm add @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest all-contributors-cli@latest cspell@latest eslint@latest eslint-config-prettier@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-import@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest npm-package-json-lint@latest npm-package-json-lint-config-default@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest sentences-per-line@latest should-semantic-release@latest tsup@latest typescript@latest yaml-eslint-parser@latest release-it@latest @vitest/coverage-v8@latest console-fail-test@latest eslint-plugin-no-only-tests@latest eslint-plugin-vitest@latest vitest@latest -D",
4848
],
4949
[
5050
"npx all-contributors-cli generate",

src/steps/finalizeDependencies.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export async function finalizeDependencies({
4949

5050
if (unitTests) {
5151
devDependencies.push(
52-
"@vitest/coverage-istanbul",
52+
"@vitest/coverage-v8",
5353
"console-fail-test",
5454
"eslint-plugin-no-only-tests",
5555
"eslint-plugin-vitest",

src/steps/writing/creation/rootFiles.ts

-1
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,6 @@ export default defineConfig({
304304
all: true,
305305
exclude: ["lib"],
306306
include: ["src"],
307-
provider: "istanbul",
308307
reporter: ["html", "lcov"],
309308
},
310309
exclude: ["lib", "node_modules"],

vitest.config.ts

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ export default defineConfig({
77
all: true,
88
exclude: ["lib"],
99
include: ["src"],
10-
provider: "istanbul",
1110
reporter: ["html", "lcov"],
1211
},
1312
exclude: ["lib", "node_modules"],

0 commit comments

Comments
 (0)