Skip to content

Commit b0f43d7

Browse files
chore: match .all-contributorsrc to template (#1140)
## PR Checklist - [x] Addresses an existing open issue: fixes #1086 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Corrects the emojis and indentation in the `badgeTemplate` property. Also sets `commitType` manually per #1090 - leaving the issue open.
1 parent 7390c17 commit b0f43d7

File tree

4 files changed

+9
-20
lines changed

4 files changed

+9
-20
lines changed

Diff for: .all-contributorsrc

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
{
2-
"badgeTemplate": "<a href=\"#contributors\" target=\"_blank\"><img alt=\"All Contributors: <%= contributors.length %> 🤝\" src=\"https://img.shields.io/badge/all_contributors-<%= contributors.length %>_🤝-21bb42.svg\" /></a>",
2+
"badgeTemplate": "\t<a href=\"#contributors\" target=\"_blank\"><img alt=\"All Contributors: <%= contributors.length %> 👪\" src=\"https://img.shields.io/badge/all_contributors-<%= contributors.length %>_👪-21bb42.svg\" /></a>",
33
"commit": false,
44
"commitConvention": "angular",
5+
"commitType": "docs",
56
"contributors": [
67
{
78
"avatar_url": "https://avatars.githubusercontent.com/u/3335181?v=4",
@@ -381,6 +382,5 @@
381382
"projectName": "create-typescript-app",
382383
"projectOwner": "JoshuaKGoldberg",
383384
"repoHost": "https://github.com",
384-
"repoType": "github",
385-
"commitType": "docs"
385+
"repoType": "github"
386386
}

Diff for: README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<p align="center">
66
<!-- prettier-ignore-start -->
77
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
8-
<a href="#contributors" target="_blank"><img alt="All Contributors: 39 🤝" src="https://img.shields.io/badge/all_contributors-39_🤝-21bb42.svg" /></a>
8+
<a href="#contributors" target="_blank"><img alt="All Contributors: 39 👪" src="https://img.shields.io/badge/all_contributors-39_👪-21bb42.svg" /></a>
99
<!-- ALL-CONTRIBUTORS-BADGE:END -->
1010
<!-- prettier-ignore-end -->
1111
<a href="https://codecov.io/gh/JoshuaKGoldberg/create-typescript-app" target="_blank"><img alt="Codecov Test Coverage" src="https://codecov.io/gh/JoshuaKGoldberg/create-typescript-app/branch/main/graph/badge.svg"/></a>

Diff for: script/__snapshots__/migrate-test-e2e.js.snap

+4-16
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,7 @@
33
exports[`verify .all-contributorsrc 1`] = `
44
"--- a/.all-contributorsrc
55
+++ b/.all-contributorsrc
6-
@@ -1,5 +1,5 @@
7-
{
8-
- "badgeTemplate": "<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"All Contributors: <%= contributors.length %> 🤝\\" src=\\"https://img.shields.io/badge/all_contributors-<%= contributors.length %>_🤝-21bb42.svg\\" /></a>",
9-
+ "badgeTemplate": "\\t<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"All Contributors: <%= contributors.length %> 👪\\" src=\\"https://img.shields.io/badge/all_contributors-<%= contributors.length %>_👪-21bb42.svg\\" /></a>",
10-
"commit": false,
11-
"commitConvention": "angular",
12-
"contributors": [
13-
@@ -24,363 +24,274 @@
6+
@@ -25,359 +25,271 @@
147
"name": "Jeff Wen",
158
"avatar_url": "https://avatars.githubusercontent.com/u/3297859?v=4",
169
"profile": "https://sinchang.me",
@@ -408,12 +401,7 @@ exports[`verify .all-contributorsrc 1`] = `
408401
+ "files": ["README.md"],
409402
"imageSize": 100,
410403
"projectName": "create-typescript-app",
411-
"projectOwner": "JoshuaKGoldberg",
412-
"repoHost": "https://github.com",
413-
- "repoType": "github",
414-
- "commitType": "docs"
415-
+ "repoType": "github"
416-
}"
404+
"projectOwner": "JoshuaKGoldberg","
417405
`;
418406

419407
exports[`verify .eslintignore 1`] = `
@@ -649,7 +637,7 @@ exports[`verify README.md 1`] = `
649637
<p align="center">
650638
<!-- prettier-ignore-start -->
651639
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
652-
-<a href="#contributors" target="_blank"><img alt="All Contributors: 39 🤝" src="https://img.shields.io/badge/all_contributors-39_🤝-21bb42.svg" /></a>
640+
- <a href="#contributors" target="_blank"><img alt="All Contributors: 39 👪" src="https://img.shields.io/badge/all_contributors-39_👪-21bb42.svg" /></a>
653641
+ <a href="#contributors" target="_blank"><img alt="All Contributors: 39 👪" src="https://img.shields.io/badge/all_contributors-39_👪-21bb42.svg" /></a>
654642
<!-- ALL-CONTRIBUTORS-BADGE:END -->
655643
<!-- prettier-ignore-end -->
@@ -665,7 +653,7 @@ exports[`verify README.md 1`] = `
665653
+ <img alt="Style: Prettier" src="https://img.shields.io/badge/style-prettier-21bb42.svg" />
666654
+ <img alt="TypeScript: Strict" src="https://img.shields.io/badge/typescript-strict-21bb42.svg" />
667655
<img alt="npm package version" src="https://img.shields.io/npm/v/create-typescript-app?color=21bb42" />
668-
+ <a href="#contributors" target="_blank"><img alt="All Contributors: 39 🤝" src="https://img.shields.io/badge/all_contributors-39_🤝-21bb42.svg" /></a>
656+
+ <a href="#contributors" target="_blank"><img alt="All Contributors: 39 👪" src="https://img.shields.io/badge/all_contributors-39_👪-21bb42.svg" /></a>
669657
+ <img alt="Sponsor: On GitHub 💸" src="https://img.shields.io/badge/sponsor-on_github_💸-21bb42.svg" />
670658
</p>
671659

Diff for: src/steps/writing/creation/writeAllContributorsRC.ts

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export async function writeAllContributorsRC(options: Options) {
1212
' <a href="#contributors" target="_blank"><img alt="All Contributors: <%= contributors.length %> 👪" src="https://img.shields.io/badge/all_contributors-<%= contributors.length %>_👪-21bb42.svg" /></a>',
1313
commit: false,
1414
commitConvention: "angular",
15+
commitType: "docs",
1516
contributors: existing?.contributors ?? [],
1617
contributorsPerLine: 7,
1718
contributorsSortAlphabetically: true,

0 commit comments

Comments
 (0)