Skip to content

Commit e25a47f

Browse files
authored
fix: remove visual underlines on badge links in README.md (#1030)
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖. Please fill out all fields below and make sure each item is true and [x] checked. Otherwise we may not be able to review your PR. --> ## PR Checklist - [x] Addresses an existing open issue: fixes #1027 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview This PR removes the visual underlines on badge links in README.md, introduced by the recent GitHub changes (to render the underlines by default). The problem was that the `<link>` and `<img>` tags were on separate lines, thus creating unnecessary spaces in between. These spaces were rendering empty links with an underline. 💖
1 parent 62281d8 commit e25a47f

File tree

1 file changed

+9
-19
lines changed

1 file changed

+9
-19
lines changed

README.md

+9-19
Original file line numberDiff line numberDiff line change
@@ -3,25 +3,15 @@
33
<p align="center">Quickstart-friendly TypeScript template with comprehensive, configurable, opinionated tooling. 💝</p>
44

55
<p align="center">
6-
<a href="#contributors" target="_blank">
7-
<!-- prettier-ignore-start -->
8-
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
9-
<img alt="All Contributors: 35 🤝" src="https://img.shields.io/badge/all_contributors-35_🤝-21bb42.svg" />
10-
<!-- ALL-CONTRIBUTORS-BADGE:END -->
11-
<!-- prettier-ignore-end -->
12-
</a>
13-
<a href="https://codecov.io/gh/JoshuaKGoldberg/create-typescript-app" target="_blank">
14-
<img alt="Codecov Test Coverage" src="https://codecov.io/gh/JoshuaKGoldberg/create-typescript-app/branch/main/graph/badge.svg"/>
15-
</a>
16-
<a href="https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CODE_OF_CONDUCT.md" target="_blank">
17-
<img alt="Code of Conduct: Enforced 🤝" src="https://img.shields.io/badge/code_of_conduct-enforced_🤝-21bb42" />
18-
</a>
19-
<a href="https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/LICENSE.md" target="_blank">
20-
<img alt="License: MIT 📝" src="https://img.shields.io/badge/license-MIT_📝-21bb42.svg">
21-
</a>
22-
<a href="https://github.com/sponsors/JoshuaKGoldberg" target="_blank">
23-
<img alt="Sponsor: On GitHub 💸" src="https://img.shields.io/badge/sponsor-on_github_💸-21bb42.svg" />
24-
</a>
6+
<!-- prettier-ignore-start -->
7+
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
8+
<a href="#contributors" target="_blank"><img alt="All Contributors: 35 🤝" src="https://img.shields.io/badge/all_contributors-35_🤝-21bb42.svg" /></a>
9+
<!-- ALL-CONTRIBUTORS-BADGE:END -->
10+
<!-- prettier-ignore-end -->
11+
<a href="https://codecov.io/gh/JoshuaKGoldberg/create-typescript-app" target="_blank"><img alt="Codecov Test Coverage" src="https://codecov.io/gh/JoshuaKGoldberg/create-typescript-app/branch/main/graph/badge.svg"/></a>
12+
<a href="https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CODE_OF_CONDUCT.md" target="_blank"><img alt="Code of Conduct: Enforced 🤝" src="https://img.shields.io/badge/code_of_conduct-enforced_🤝-21bb42" /></a>
13+
<a href="https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/LICENSE.md" target="_blank"><img alt="License: MIT 📝" src="https://img.shields.io/badge/license-MIT_📝-21bb42.svg"></a>
14+
<a href="https://github.com/sponsors/JoshuaKGoldberg" target="_blank"><img alt="Sponsor: On GitHub 💸" src="https://img.shields.io/badge/sponsor-on_github_💸-21bb42.svg" /></a>
2515
<img alt="Style: Prettier 🧹" src="https://img.shields.io/badge/style-prettier_🧹-21bb42.svg" />
2616
<img alt="TypeScript: Strict 💪" src="https://img.shields.io/badge/typescript-strict_💪-21bb42.svg" />
2717
<img alt="npm package version" src="https://img.shields.io/npm/v/create-typescript-app?color=21bb42" />

0 commit comments

Comments
 (0)