Skip to content

Commit e7921ee

Browse files
fix: reset post-release back to npm pkg get again (#1666)
## PR Checklist - [x] Addresses an existing open issue: fixes broken post-release after #1663 and #1665 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Sigh. 💖
1 parent ade9b84 commit e7921ee

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

.github/workflows/post-release.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ jobs:
55
- uses: actions/checkout@v4
66
with:
77
fetch-depth: 0
8+
- run: echo "npm_version=$(npm pkg get version | tr -d '"')" >> "$GITHUB_ENV"
89
- uses: apexskier/github-release-commenter@v1
910
with:
1011
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -14,7 +15,7 @@ jobs:
1415
The release is available on:
1516
1617
* [GitHub releases](https://github.com/JoshuaKGoldberg/create-typescript-app/releases/tag/{release_tag})
17-
* [npm package (@latest dist-tag)](https://www.npmjs.com/package/create-typescript-app/v/{${{ payload.release.tag_name }}})
18+
* [npm package (@latest dist-tag)](https://www.npmjs.com/package/create-typescript-app/v/${{ env.npm_version }})
1819
1920
Cheers! 📦🚀
2021

src/steps/writing/creation/dotGitHub/createWorkflows.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ describe("createWorkflows", () => {
197197
- uses: actions/checkout@v4
198198
with:
199199
fetch-depth: 0
200+
- run: echo "npm_version=$(npm pkg get version | tr -d '"')" >> "$GITHUB_ENV"
200201
- uses: apexskier/github-release-commenter@v1
201202
with:
202203
GITHUB_TOKEN: \${{ secrets.GITHUB_TOKEN }}
@@ -206,7 +207,7 @@ describe("createWorkflows", () => {
206207
The release is available on:
207208
208209
* [GitHub releases](https://github.com/StubOwner/stub-repository/releases/tag/{release_tag})
209-
* [npm package (@latest dist-tag)](https://www.npmjs.com/package/stub-repository/v/{\${{ payload.release.tag_name }}})
210+
* [npm package (@latest dist-tag)](https://www.npmjs.com/package/stub-repository/v/\${{ env.npm_version }})
210211
211212
Cheers! 📦🚀
212213

src/steps/writing/creation/dotGitHub/createWorkflows.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,9 @@ export function createWorkflows(options: Options) {
155155
},
156156
steps: [
157157
{ uses: "actions/checkout@v4", with: { "fetch-depth": 0 } },
158+
{
159+
run: `echo "npm_version=$(npm pkg get version | tr -d '"')" >> "$GITHUB_ENV"`,
160+
},
158161
{
159162
uses: "apexskier/github-release-commenter@v1",
160163
with: {
@@ -164,7 +167,7 @@ export function createWorkflows(options: Options) {
164167
The release is available on:
165168
166169
* [GitHub releases](https://github.com/${options.owner}/${options.repository}/releases/tag/{release_tag})
167-
* [npm package (@latest dist-tag)](https://www.npmjs.com/package/${options.repository}/v/{\${{ payload.release.tag_name }}})
170+
* [npm package (@latest dist-tag)](https://www.npmjs.com/package/${options.repository}/v/\${{ env.npm_version }})
168171
169172
Cheers! 📦🚀
170173
`,

0 commit comments

Comments
 (0)