Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --bin option #1068

Merged
merged 1 commit into from
Dec 1, 2023
Merged

feat: add --bin option #1068

merged 1 commit into from
Dec 1, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 1, 2023

PR Checklist

Overview

Adds the --bin option with auto-detection from existing package.json contents.

Doesn't do anything about investigating whether to adjust pnpm build before pnpm lint & similar. That can be a followup.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3cba74b) 74.63% compared to head (bacb5fa) 94.17%.
Report is 5 commits behind head on main.

Files Patch % Lines
src/shared/types.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1068       +/-   ##
===========================================
+ Coverage   74.63%   94.17%   +19.54%     
===========================================
  Files          91       96        +5     
  Lines        5413     5564      +151     
  Branches      209      446      +237     
===========================================
+ Hits         4040     5240     +1200     
+ Misses       1368      323     -1045     
+ Partials        5        1        -4     
Flag Coverage Δ
create 70.67% <100.00%> (?)
initialize 41.83% <88.88%> (+0.07%) ⬆️
migrate 69.83% <100.00%> (+0.04%) ⬆️
unit 72.03% <81.81%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 21c8529 into main Dec 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the bin-option branch December 1, 2023 19:44
Copy link

github-actions bot commented Dec 1, 2023

🎉 This is included in version v1.48.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add a --bin option for projects with a bin runner
1 participant