Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve migration owner replacements #1078

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Uses a to callback to determine whether to swap out owner to options.owner in "JoshuaKGoldberg" (always) or "JoshuaKGoldberg/..." (if the ... is options.repository).

Also fixes some existing edge cases around owner replacements:

  • Syncs up the end-of-readme attribution notice so there's only one place it's written in the templates
  • Uses options.owner and options.repository in createDotGitHubFiles instead of hardcoding JoshuaKGoldberg/create-typescript-app.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (df82c12) 92.83% compared to head (dcc76b2) 94.20%.

Files Patch % Lines
src/steps/updateLocalFiles.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
+ Coverage   92.83%   94.20%   +1.36%     
==========================================
  Files          96       97       +1     
  Lines        5571     5609      +38     
  Branches      438      455      +17     
==========================================
+ Hits         5172     5284     +112     
+ Misses        398      324      -74     
  Partials        1        1              
Flag Coverage Δ
create 70.36% <30.61%> (-0.28%) ⬇️
initialize 42.18% <87.75%> (+0.34%) ⬆️
migrate 69.83% <69.38%> (?)
unit 72.14% <81.63%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4e25327 into main Dec 7, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the specific-owner-replacements branch December 7, 2023 18:25
Copy link

github-actions bot commented Dec 7, 2023

🎉 This is included in version v1.49.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Migrating a non-JoshuaKGoldberg repo creates the wrong owners for JoshuaKGoldberg actions
1 participant