Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use repository name in README.md npm package badge #1109

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Replaces the hardcoded create-typescript-app name with options.repository. Also adds non-blank strings to unit tests so the snapshots will reflect this.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (127108f) 94.25% compared to head (60396ab) 94.25%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1109   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          97       97           
  Lines        5625     5625           
  Branches      454      454           
=======================================
  Hits         5302     5302           
  Misses        322      322           
  Partials        1        1           
Flag Coverage Δ
create 70.21% <100.00%> (ø)
initialize 42.15% <0.00%> (ø)
migrate 69.55% <100.00%> (ø)
unit 72.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 728eb4b into main Dec 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the correct-npm-badge branch December 22, 2023 05:31
Copy link

🎉 This is included in version v1.49.4 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Created npm package version badge in README.md uses wrong package name
1 participant