Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated source.fixAll.eslint to explicit #1110

Merged
merged 4 commits into from
Dec 24, 2023
Merged

feat: Updated source.fixAll.eslint to explicit #1110

merged 4 commits into from
Dec 24, 2023

Conversation

PraveenShinde3
Copy link
Contributor

PR Checklist

Overview

Updated source.fixAll.eslint to "explicit"

image

@codecov Codecov
Copy link

codecov bot commented Dec 22, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (728eb4b) 94.25% compared to head (18599ce) 94.25%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1110   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          97       97           
  Lines        5625     5625           
  Branches      454      454           
=======================================
  Hits         5302     5302           
  Misses        322      322           
  Partials        1        1
Flag Coverage Δ
create 70.21% <100.00%> (ø)
initialize 42.15% <0.00%> (ø)
migrate 69.55% <100.00%> (ø)
unit 72.31% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Dec 22, 2023
Open
JoshuaKGoldberg
JoshuaKGoldberg requested changes Dec 22, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A start 🙌

JoshuaKGoldberg
JoshuaKGoldberg requested changes Dec 22, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks really close to merge! Just a couple of touchups 🙂

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Dec 22, 2023
@PraveenShinde3 @JoshuaKGoldberg
Update .vscode/settings.json
6f971ab 
Co-authored-by: Josh Goldberg ✨ <[email protected]>
@PraveenShinde3 PraveenShinde3 changed the title Updated source.fixAll.eslint to explicit feat: Updated source.fixAll.eslint to explicit Dec 23, 2023
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Dec 24, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell, thanks!

Stop-motion sheep giving two thumbs up

@JoshuaKGoldberg JoshuaKGoldberg merged commit 274ec71 into JoshuaKGoldberg:main Dec 24, 2023
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @PraveenShinde3 for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Dec 24, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @PraveenShinde3! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.50.0 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Dec 24, 2023
@allcontributors
docs: add praveenshinde3 as a contributor for code (#1113)
912dd01 
Adds @PraveenShinde3 as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#1110 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
status: waiting for author Needs an action taken by the original poster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: .vscode/settings.json should set source.fixAll.eslint to "explicit", not true
2 participants
@PraveenShinde3 @JoshuaKGoldberg