Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Tooling: Use --auto in end-to-end migration test #1157

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 31, 2023 · 2 comments · Fixed by #1612
Closed
3 tasks done

🛠 Tooling: Use --auto in end-to-end migration test #1157

JoshuaKGoldberg opened this issue Dec 31, 2023 · 2 comments · Fixed by #1612
Assignees
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 31, 2023

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

I'd added an --auto mode in #1046. It'd be nice to have it be used in the end-to-end migration task. That way the test won't need to manually declare values in the CLI

This wouldn't IMO change how thorough the test is: instead of testing each of those options' ability to be read from CLI values, it'd instead test that they can be inferred by --auto.

Additional Info

I suppose a second end-to-end test could be added - so that one tests --auto while the other tests manual values? I don't think that'd be worth the overhead though. At least unless and until the performance work in #860 makes the end-to-end tests very fast.

@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Dec 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Simpler Snapshots milestone Jan 9, 2024
@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg commented Aug 11, 2024

I tried this out locally and found quite a few changes:

  • .github/CODE_OF_CONDUCT.md: Under ## Enforcement, the email was switched from [email protected] to [email protected]
  • .github/DEVELOPMENT.md: The initial > If you'd like a more guided walkthrough, ... is missing
  • .github/SECURITY.md: The email was switched from [email protected] to [email protected]
  • .vscode/launch.json: The Debug Program task was removed
  • package.json:
    • The name was switched from "JoshuaKGoldberg" to "Josh Goldberg"
    • The "bin" entry was missing, as well as "bin/index.js" under "files"

These seem to be product bugs in --auto caught. Nice!

Edit: filed #1613.

Copy link

🎉 This is included in version v1.67.3 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant