Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Unnecessary || exit 0 in post-run files cleanup #1160

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 31, 2023 · 1 comment
Closed
3 tasks done

🐛 Bug: Unnecessary || exit 0 in post-run files cleanup #1160

JoshuaKGoldberg opened this issue Dec 31, 2023 · 1 comment
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

It makes sense to pnpm build in post-run cleanup. I'd added it in #1152. Despite what I thought while writing that PR, I now think it makes sense to let the user know if that command fails.

Actual

The PR added an exit 0:

create-typescript-app/src/shared/createCleanUpFilesCommands.ts

Line 14 in 01704e9

...(bin ? ["pnpm build || exit 0"] : []),

On second thought, let's remove that.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 31, 2023
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Owner Author

Fixed by #1161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg