Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print logo in README.md #1166

Merged
merged 3 commits into from
Dec 31, 2023
Merged

fix: print logo in README.md #1166

merged 3 commits into from
Dec 31, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Hooks the logo up to README.md generation and uses --logo in the end-to-end migration test.

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c5e15e4) 94.30% compared to head (016d6df) 94.33%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/steps/writeReadme/generateTopContent.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
+ Coverage   94.30%   94.33%   +0.02%     
==========================================
  Files          99       99              
  Lines        5657     5666       +9     
  Branches      459      462       +3     
==========================================
+ Hits         5335     5345      +10     
+ Misses        321      320       -1     
  Partials        1        1              
Flag Coverage Δ
create 70.19% <55.55%> (-0.03%) ⬇️
initialize 42.41% <11.11%> (-0.06%) ⬇️
migrate 69.75% <55.55%> (+0.10%) ⬆️
unit 72.25% <55.55%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🎉 This is included in version v1.52.3 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Logo option isn't printed to README.md
1 participant