Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Remove skipCi from allcontributors PRs #151

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 24, 2022 · 0 comments · Fixed by #152
Closed
3 tasks done

🛠 Tooling: Remove skipCi from allcontributors PRs #151

JoshuaKGoldberg opened this issue Dec 24, 2022 · 0 comments · Fixed by #152
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Per https://allcontributors.org/docs/en/bot/configuration, skipCi in .allcontributors-rc indicates to include a [skip-ci] line at the bottom of the PR body. Example: #149 (comment) (see before any of my text edits).

That [skip-ci] line does stop GitHub from running CI on the PR. Which is nifty. But, with branch protections enabled, the PR then can't be merged (unless you bypass the branch protection) because Ci status checks are required!

There's no real need to [skip-ci]. It'd be good to know if an allcontributors PR introduces a build break.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Dec 24, 2022
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 24, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 24, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't skipCi for allcontributors JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg