Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡️ Performance: Run pnpm dedupe in --offline mode during setup #1610

Closed
JoshuaKGoldberg opened this issue Aug 11, 2024 · 1 comment · Fixed by #1611
Closed

⚡️ Performance: Run pnpm dedupe in --offline mode during setup #1610

JoshuaKGoldberg opened this issue Aug 11, 2024 · 1 comment · Fixed by #1611
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Overview

Splitting out of #860: per pnpm/pnpm#6619 (comment), pnpm dedupe --offline is quite a bit faster than the non---offline version. I tried this out locally with hyperfine and it went from 4.013 s to 2.016 s mean. Nice! ⚡
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Aug 11, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 11, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 11, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.67.2 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 11, 2024
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 25, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: run pnpm dedupe --offline in cleanups JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg