Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: --exclude-lint-md does not exclude extension from extensions.json #1622

Closed
3 tasks done
johnnyreilly opened this issue Aug 13, 2024 · 2 comments · Fixed by #1625
Closed
3 tasks done

🐛 Bug: --exclude-lint-md does not exclude extension from extensions.json #1622

johnnyreilly opened this issue Aug 13, 2024 · 2 comments · Fixed by #1625
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@johnnyreilly
Copy link
Collaborator

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Using the --exclude-lint-md flag I would expect "DavidAnson.vscode-markdownlint", to not be included in extensions.json.

Actual

But it is - probably because of this code:

create-typescript-app/src/steps/writing/creation/dotVSCode.ts

Line 9 in 0ff914c

"DavidAnson.vscode-markdownlint",

Is this intentional?

Additional Info

No response
@johnnyreilly johnnyreilly added the type: bug Something isn't working :( label Aug 13, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Aug 13, 2024
@JoshuaKGoldberg
Copy link
Owner

🐛❗

@JoshuaKGoldberg JoshuaKGoldberg added the good first issue Good for newcomers, please hop on! label Aug 13, 2024
@johnnyreilly johnnyreilly mentioned this issue Aug 13, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.67.7 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: should not include extensions for markdown when excluded JoshuaKGoldberg/create-typescript-app
2 participants
@johnnyreilly @JoshuaKGoldberg