Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Test files shouldn't be published #1629

Closed
2 tasks done
JoshuaKGoldberg opened this issue Aug 14, 2024 · 5 comments · Fixed by #1637 or #1642
Closed
2 tasks done

🚀 Feature: Test files shouldn't be published #1629

JoshuaKGoldberg opened this issue Aug 14, 2024 · 5 comments · Fixed by #1637 or #1642
Assignees
@johnnyreilly
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Aug 14, 2024 •
edited
Loading

Bug Report Checklist

Overview

Right now, CTA repos publish all files under lib/:

create-typescript-app/package.json

Lines 17 to 23 in 9034d25

"files": [
"bin/index.js",
"lib/",
"package.json",
"LICENSE.md",
"README.md"
],

...including *.test.* files. 😬. That's a lot of extra file size on published packages for no real gain. I think *.test.* files should be excluded from the published outputs.

Additional Info

I'd previously fixed this in 7cdb836, but at some point switched away from .npmignore files and lost that.

💖
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Aug 14, 2024
@johnnyreilly
Copy link
Collaborator

Is this as simple as re-introducing an .npmignore with this content?:

*.test.*

@JoshuaKGoldberg
Copy link
Owner Author

I think so!

@johnnyreilly johnnyreilly self-assigned this Aug 15, 2024
@johnnyreilly
Copy link
Collaborator

Let me PR - just heading out so hopefully tomorrow

@johnnyreilly johnnyreilly mentioned this issue Aug 15, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.71.4 🎉

The release is available on:

Cheers! 📦🚀

@johnnyreilly johnnyreilly mentioned this issue Aug 24, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.72.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnnyreilly johnnyreilly

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
2 participants
@johnnyreilly @JoshuaKGoldberg