Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run build prior to release #166

Merged
merged 4 commits into from
Dec 26, 2022
Merged

fix: run build prior to release #166

merged 4 commits into from
Dec 26, 2022

Conversation

johnnyreilly
Copy link
Collaborator

@johnnyreilly johnnyreilly commented Dec 26, 2022

PR Checklist

Overview

This PR adds in a build step to the release.yml so the build artefacts exist for publishing. It also excludes src from publishing as it bloats package size and isn't used.

PR requested here: #147 (comment)

It also ensure vitest doesn't try and run tests in the lib folder.

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Merging #166 (834cf95) into main (2885cc3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            6         6           
  Branches         3         3           
=========================================
  Hits             6         6           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Perfect, thanks @johnnyreilly!

@JoshuaKGoldberg
Copy link
Owner

@allcontributors add @johnnyreilly for code

@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @johnnyreilly! 🎉

@JoshuaKGoldberg JoshuaKGoldberg merged commit c83355b into main Dec 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix/release branch December 26, 2022 15:34
@johnnyreilly
Copy link
Collaborator Author

Pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: published npm packages have src/ but not lib/
3 participants