fix: default skipRestore to true when mode is create #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Dec 21, 2024
| (JSON.parse(await readFileSafe("./package.json", "{}")) as | ||
| | PartialPackageData | ||
| | undefined) ?? {} | ||
| ); |
There was a problem hiding this comment.
Supports migration mode when package.json doesn't exist. An accidental bugfix from failing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
When
modeis"create",options.skipRestorenow has an additional??to set it totrue.Most of the time spent here is adjusting mocks, since
readOptionspreviously always ran in that mode. Looking forward to the newcreateengine to make this much more automatic and inferred. 😎💖