Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use cspell-populate-words in CSpell block #1794

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 21, 2024

Overview

Applies only to the new create engine Block system, because it'd be a nontrivial change in the old system, and I want that old system to be gone within the next few weeks. 🚀

Uses:

  1. object-strings-deep to collect all strings from options
  2. cspell-populate-words in a new script to add any reported words to the cspell.json file

Scoping the PR as a chore: because the new system is not yet part of the public API.

💖

@JoshuaKGoldberg JoshuaKGoldberg merged commit c7a0881 into main Dec 21, 2024
11 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the block-cspell-populate-words branch December 21, 2024 21:51
JoshuaKGoldberg added a commit that referenced this pull request Mar 28, 2025
## PR Checklist

- [x] Addresses an existing open issue: fixes #2062
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

_Setup_ mode already populated words as of #1794. I confirmed in
JoshuaKGoldberg/eslint-fix-utils#79 that `pnpm
lint:spelling` passes without these.

🎁
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Have cspell automatically detect values from the package
1 participant