Skip to content

🛠 Tooling: Migration test failures on main from version mismatch #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 26, 2024 · 1 comment
Closed
3 tasks done
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 26, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

#1803 added the "description" line in package.json to script/__snapshots__/migrate-test-e2e.ts.snap. Unfortunately, that also added in the "version" line, which is failing end-to-end tests.

Example from https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/12498490322/job/34890238040?pr=1810:

@@ -1,11 +1,11 @@
  "--- a/package.json
  +++ b/package.json
  @@ ... @@
   {
   	"name": "create-typescript-app",
-  	"version": "1.78.0",
+  	"version": "1.79.0",
  -	"description": "Quickstart-friendly TypeScript template with comprehensive, configurable, opinionated tooling. ❤️‍🔥",
  +	"description": "A very lovely package. Hooray!",

Additional Info

For now, I think make the description-defaulting logic added in #1804 just ignore this repo... Ah, but that's not yet known at the time... hmm..

💖

@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Dec 26, 2024
@JoshuaKGoldberg
Copy link
Owner Author

Well, for now I fixed this in c047820. Hoping to do away with this system soon anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Development

No branches or pull requests

1 participant