Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Vitest coverage doesn't need to exclude lib/ #1816

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 31, 2024 · 0 comments · Fixed by #1818
Closed
3 tasks done

🐛 Bug: Vitest coverage doesn't need to exclude lib/ #1816

JoshuaKGoldberg opened this issue Dec 31, 2024 · 0 comments · Fixed by #1818
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

In vitest.config.ts, because test.exclude includes "lib", there's no need for test.coverage.exclude to as well.

Actual

create-typescript-app/vitest.config.ts

Line 8 in 2714393

exclude: ["lib"],

Additional Info

💖
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 31, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 31, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 31, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
1 participant
@JoshuaKGoldberg