Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Release-it release commits blocked by new repository rulesets #1838

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 13, 2025 · 2 comments · Fixed by #1840
Closed
3 tasks done

🐛 Bug: Release-it release commits blocked by new repository rulesets #1838

JoshuaKGoldberg opened this issue Jan 13, 2025 · 2 comments · Fixed by #1840
Assignees
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

When the Release flow has a change to the package.json, it should be able to commit it in CI.

Actual

The ruleset I added in #1788 & tried to fix in #1791 is still not allowing the CI job to push.

Additional Info

I suspect the right long-term fix would be GitHub Deploy Keys. But for now I think I'm just going to remove the requirement that changes be sent in PRs.

💖

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Jan 13, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 13, 2025
@JoshuaKGoldberg
Copy link
Owner Author

😕 removing the requirement of a PR still leaves the requirement of passing CI status:

ERROR remote: error: GH013: Repository rule violations found for refs/heads/main.        
remote: Review all repository rules at https://github.com/JoshuaKGoldberg/cta-publish-testing/rules?ref=refs%2Fheads%2Fmain        
remote: 
remote: - 5 of 5 required status checks are expected.        

@JoshuaKGoldberg JoshuaKGoldberg changed the title 🐛 Bug: Release-it release PRs blocked by new repository rulesets 🐛 Bug: Release-it release commits blocked by new repository rulesets Jan 13, 2025
@JoshuaKGoldberg
Copy link
Owner Author

I think I figured it out. The release job should be running as whatever user+permissions are provided by the ACCESS_TOKEN secret. But they're not getting those permissions.

I found references in a few StackOverflow answers -most helpfully, https://stackoverflow.com/questions/71669640/bypass-required-status-checks-in-github- to using the token in actions/checkout. And that seemed to fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant