Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add an addon for Knip ignoreDependencies #1851

Closed
2 tasks done
JoshuaKGoldberg opened this issue Jan 14, 2025 · 0 comments · Fixed by #1863
Closed
2 tasks done

🚀 Feature: Add an addon for Knip ignoreDependencies #1851

JoshuaKGoldberg opened this issue Jan 14, 2025 · 0 comments · Fixed by #1863
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

Overview

This repo uses a couple of dependencies in a fancy way that bypasses reasonable detection flows for Knip:

create-typescript-app/knip.json

Line 4 in 5bd6122

"ignoreDependencies": ["all-contributors-cli", "cspell-populate-words"],

I'll go ahead and add a Knip Block addon for that.

Additional Info

I don't plan on adding this to the legacy engine, just create blocks.

Prototyped in #1839.
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Jan 14, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 14, 2025
This was referenced Jan 14, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add addons.ignoreDependencies to blockKnip JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg