Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: blockPackageJson inverts --offline #1890

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 16, 2025 · 0 comments · Fixed by #1893
Closed
3 tasks done

🐛 Bug: blockPackageJson inverts --offline #1890

JoshuaKGoldberg opened this issue Jan 16, 2025 · 0 comments · Fixed by #1893
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

If offline, pnpm install --offline.

Actual

create-typescript-app/src/next/blocks/blockPackageJson.ts

Lines 104 to 107 in 9307ea2

commands: [
offline ? "pnpm install" : "pnpm install --offline",
...addons.cleanupCommands,
],

Additional Info

sigh

Prototyped in #1839.

💖
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Jan 16, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 16, 2025
This was referenced Jan 16, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correct --offline ternary in blockPackageJson JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg