Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add README.md contributors section in setup #1958

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

The previous pnpx all-contributors-cli command was only enough for transition mode to pick up on existing contributors and create a README.md section. For setup mode, there needed to be a default in options if .all-contributorsrc doesn't yet exist. That's now pulled from the GitHub API.

🎁

@JoshuaKGoldberg JoshuaKGoldberg merged commit 810eaad into main Mar 6, 2025
12 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the all-contributors-setup-section branch March 6, 2025 13:22
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (8ca464e) to head (2b88625).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1958      +/-   ##
==========================================
+ Coverage   95.43%   95.46%   +0.03%     
==========================================
  Files          87       89       +2     
  Lines        3591     3618      +27     
  Branches      207      210       +3     
==========================================
+ Hits         3427     3454      +27     
  Misses        164      164              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: All Contributors table not created in setup mode
1 participant