Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Switch requests to new serialized Bingo requests #1977

Closed
2 tasks done
JoshuaKGoldberg opened this issue Mar 12, 2025 · 2 comments · Fixed by #1978
Closed
2 tasks done

🚀 Feature: Switch requests to new serialized Bingo requests #1977

JoshuaKGoldberg opened this issue Mar 12, 2025 · 2 comments · Fixed by #1978
Assignees
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Feature Request Checklist

Overview

Coming over from JoshuaKGoldberg/bingo#65 -> JoshuaKGoldberg/bingo#278: Bingo requests are now serializable, typed objects - not general send functions.

Additional Info

I'm working on this now because this blocks CTA from updating to new Bingo versions. JoshuaKGoldberg/bingo#65 blocked JoshuaKGoldberg/bingo#275, which I want to fix Soon ™ so that non-authenticated users don't get annoying error reports on the CLI.

🎁

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request labels Mar 12, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 12, 2025
@JoshuaKGoldberg
Copy link
Owner Author

The biggest difficulty here is labels. The block uses https://github.com/JoshuaKGoldberg/set-github-repository-labels right now to abstract that logic:

async send() {
await setGitHubRepositoryLabels({
labels: outcomeLabels,
owner: options.owner,
repository: options.repository,
});

I'll:

  • Extract out a determineLabelChanges function from set-github-repository-labels
  • Add an existingLabels option to the Stratum Base
  • Pass existingLabels to determineLabelChanges to generate the list of requests

Copy link

🎉 This is included in version v2.5.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant