Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Transition mode should not lower package.json dependency versions #1997

Closed
3 tasks done
JoshuaKGoldberg opened this issue Mar 20, 2025 · 1 comment · Fixed by #1999
Closed
3 tasks done
Assignees
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Mar 20, 2025

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Many repos set up with CTA have Renovate automatically bumping npm dependencies to their latest versions. If:

  1. An npm dependency is bumped in a repo
  2. npx create-typescript-app run in that repo resolves to a CTA with an older version of that dependency

...then the repo will get downgraded back down to the older version.

Actual

The package.json Block should check if there's an existing version for deps, and use the greater of (it, CTA's). That way transition mode won't lower versions in package.jsons.

Additional Info

Sibling issue for GHA deps: #1998

🎁

Copy link

🎉 This is included in version v2.7.3 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
1 participant