Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: CTA Transitions action doesn't preserve existing uses pins #2038

Closed
3 tasks done
JoshuaKGoldberg opened this issue Mar 27, 2025 · 1 comment · Fixed by #2054
Closed
3 tasks done

🐛 Bug: CTA Transitions action doesn't preserve existing uses pins #2038

JoshuaKGoldberg opened this issue Mar 27, 2025 · 1 comment · Fixed by #2054
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Transition Mode D...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

All GitHub Actions .yml files should preserve pinned hashes and versions during transitions.

Actual

https://github.com/JoshuaKGoldberg/all-contributors-auto-action/pull/906/files#diff-9e82cd68c6c53993b84c1dd2eda284f2f38f4bb4d1948381b8de0ffb9a3e6916 shows two uses not respecting existing version pins:

  • stefanzweifel/git-auto-commit-action@v5
  • mshick/add-pr-comment@v2

Additional Info

🎁
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Mar 27, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 27, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 27, 2025
Merged
3 tasks
@github-actions GitHub Actions
Copy link

🎉 This is included in version v2.17.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Transition Mode Dogfooding
Development

Successfully merging a pull request may close this issue.

fix: pin actions versions in cta-transitions.yml JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg