Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: perserve peerDependencies, peerDependenciesMeta in transition mode #2061

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Expands the options.packageData schema to allow them. These are the first allowlisted package.json properties that aren't manually combined with addons, so they're generally spread in blockPackageJson.

🎁

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (91824c6) to head (9f2f4bb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2061   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files         120      120           
  Lines        4996     4999    +3     
  Branches      313      313           
=======================================
+ Hits         4987     4990    +3     
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 1f1e989 into main Mar 28, 2025
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the preserve-peer-deps branch March 28, 2025 14:26
Copy link

🎉 This is included in version v2.18.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: package.json removes existing peerDependencies, peerDependenciesMeta
1 participant