Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: ESLint config groups should be deduplicated by comment #2133

Closed
3 tasks done
JoshuaKGoldberg opened this issue Apr 4, 2025 · 1 comment · Fixed by #2139
Closed
3 tasks done

🐛 Bug: ESLint config groups should be deduplicated by comment #2133

JoshuaKGoldberg opened this issue Apr 4, 2025 · 1 comment · Fixed by #2139
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

If two rules objects from blockESLint's Addons have the same comment, they should be merged together. This will allow end-users to add to the default // Stylistic concerns that don't interfere with Prettier group.

Actual

https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/pull/993/files#r2027963553 shows that no such merging is done now.

Additional Info

🎁
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Apr 4, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 4, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 4, 2025
Draft
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg removed their assignment Apr 4, 2025
@JoshuaKGoldberg JoshuaKGoldberg removed this from the Transition Mode Dogfooding milestone Apr 4, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 4, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 4, 2025
Merged
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025

🎉 This is included in version v2.26.4 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: deduplicate blockESLint rule groups by comment JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg