Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Run "Cleaning up files" section after initialization and migration too #705

Closed
3 tasks done
JoshuaKGoldberg opened this issue Aug 25, 2023 · 1 comment
Closed
3 tasks done
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, after someone runs npx template-typescript-node-package, the create setup script will run a few commands to autofix / clean up files:

https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/a386c870f5bc53ce3b30a8d31108c5726487ba78/src/create/createWithOptions.ts#L35-L39

Those feel broadly useful to me for all the other two setup script forms too: initialize and migrate. Let's run the same bit of code at the end of all three of them!

Additional Info

I see that initializeWithOptions and migrateWithOptions already run a couple of those commands:

https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/a386c870f5bc53ce3b30a8d31108c5726487ba78/src/initialize/initializeWithOptions.ts#L49-L52

https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/a386c870f5bc53ce3b30a8d31108c5726487ba78/src/migrate/migrateWithOptions.ts#L44-L47

I don't know why they don't run all three 😂. This is probably a good sign that there should be a single shared function to call the three scripts. For reference, initializeGitHubRepository is another shared function that's run in all three setup scripts.

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Aug 25, 2023
@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg commented Jan 9, 2024

This was done... at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

1 participant