feat: added --logo and --logo-alt #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #851 +/- ##
==========================================
+ Coverage 92.32% 92.38% +0.06%
==========================================
Files 87 87
Lines 4405 4453 +48
Branches 284 294 +10
==========================================
+ Hits 4067 4114 +47
- Misses 338 339 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JoshuaKGoldberg
changed the title
3 tasks
JoshuaKGoldberg
added a commit
that referenced
this pull request
Sep 21, 2023
## PR Checklist - [x] Addresses an existing open issue: fixes #542 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Builds off the ideas in #851 by adding optional `--email-github` and `--email-npm` overrides. Adds a string complaint if an improper combination is specified: one of those two without the other or `email`, or both of those two along with `email`. At this point `email` is now a required option. Adjusts the sorting of rerun suggestions a bit to make sure emails are sorted inline and `--base` comes immediately after `--mode`. Also fills in some unit test coverage in the area.
|
🎉 This is included in version v1.32.0 🎉 The release is available on: Cheers! 📦🚀 |
This was referenced Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Adds in options to put an image in the README.md, and uses them in this repo with the "new" logo. (it's really TypeStat's old logo)
While I'm in the area, fills in test coverage for
readOptions.test.ts. I also noticed it was taking >500ms to run sometimes. Turns out it wasn't mockingreadOptionDefaults! 😱