feat: allow specific GitHub and/or npm emails #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #858 +/- ##
==========================================
+ Coverage 92.38% 92.50% +0.12%
==========================================
Files 87 89 +2
Lines 4453 4538 +85
Branches 294 322 +28
==========================================
+ Hits 4114 4198 +84
Misses 339 339
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JoshuaKGoldberg
force-pushed
the
emails-split
branch
from
6929757 to
52893c9
Compare
|
🎉 This is included in version v1.32.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Builds off the ideas in #851 by adding optional
--email-githuband--email-npmoverrides. Adds a string complaint if an improper combination is specified: one of those two without the other oremail, or both of those two along withemail. At this pointemailis now a required option.Adjusts the sorting of rerun suggestions a bit to make sure emails are sorted inline and
--basecomes immediately after--mode.Also fills in some unit test coverage in the area.