fix: correct create-repository-by-default logic

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes 🚀 Feature: Remove "Would you like to push the template's tooling up to the repository on GitHub?" #920 (but better)
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

I remember now why --create-repository existed: if mode is create, then we'll want to attempt creating a new repo by default. So this PR infers a createRepository again in ensureRepositoryExists.

[codecov]

Codecov Report

Merging #922 (8aa4156) into main (ebde1d9) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage   93.43%   93.44%           
=======================================
  Files          90       90           
  Lines        4873     4880    +7     
  Branches      399      401    +2     
=======================================
+ Hits         4553     4560    +7     
  Misses        319      319           
  Partials        1        1           

Flag	Coverage Δ
create	71.90% <12.00%> (-0.07%)	⬇️
initialize	37.60% <12.00%> (-0.02%)	⬇️
migrate	70.76% <12.00%> (-0.07%)	⬇️
unit	68.19% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/shared/options/ensureRepositoryExists.ts	93.33% <100.00%> (+0.47%)	⬆️
src/shared/options/readOptions.ts	92.27% <100.00%> (+0.03%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

🎉 This is included in version v1.32.0 🎉

The release is available on:

• GitHub releases
• npm package (@latest dist-tag)

Cheers! 📦🚀