From 0ad2ae3db2cee72d7fab5901128df31e725387e1 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Tue, 14 Jan 2025 19:26:18 -0500 Subject: [PATCH] chore: use formatIgnoreFile in remaining blocks --- src/next/blocks/blockMarkdownlint.test.ts | 6 ++++-- src/next/blocks/blockMarkdownlint.ts | 17 +++++++++-------- src/next/blocks/blockPrettier.test.ts | 9 ++++++--- src/next/blocks/blockPrettier.ts | 7 ++++--- 4 files changed, 23 insertions(+), 16 deletions(-) diff --git a/src/next/blocks/blockMarkdownlint.test.ts b/src/next/blocks/blockMarkdownlint.test.ts index 749d10271..db0074018 100644 --- a/src/next/blocks/blockMarkdownlint.test.ts +++ b/src/next/blocks/blockMarkdownlint.test.ts @@ -78,7 +78,8 @@ describe("blockMarkdownlint", () => { ".markdownlint.json": "{"extends":"markdownlint/style/prettier","first-line-h1":false,"no-inline-html":false}", ".markdownlintignore": ".github/CODE_OF_CONDUCT.md CHANGELOG.md - node_modules/", + node_modules/ + ", }, "scripts": [ { @@ -169,7 +170,8 @@ describe("blockMarkdownlint", () => { ".markdownlintignore": ".github/CODE_OF_CONDUCT.md CHANGELOG.md lib/ - node_modules/", + node_modules/ + ", }, "scripts": [ { diff --git a/src/next/blocks/blockMarkdownlint.ts b/src/next/blocks/blockMarkdownlint.ts index 0f1cd9002..c3e9a75f7 100644 --- a/src/next/blocks/blockMarkdownlint.ts +++ b/src/next/blocks/blockMarkdownlint.ts @@ -1,5 +1,6 @@ import { z } from "zod"; +import { formatIgnoreFile } from "../../steps/writing/creation/formatters/formatIgnoreFile.js"; import { base } from "../base.js"; import { blockCSpell } from "./blockCSpell.js"; import { blockDevelopmentDocs } from "./blockDevelopmentDocs.js"; @@ -66,14 +67,14 @@ export const blockMarkdownlint = base.createBlock({ "first-line-h1": false, "no-inline-html": false, }), - ".markdownlintignore": [ - ".github/CODE_OF_CONDUCT.md", - "CHANGELOG.md", - "node_modules/", - ...ignores, - ] - .sort() - .join("\n"), + ".markdownlintignore": formatIgnoreFile( + [ + ".github/CODE_OF_CONDUCT.md", + "CHANGELOG.md", + "node_modules/", + ...ignores, + ].sort(), + ), }, scripts: [ { diff --git a/src/next/blocks/blockPrettier.test.ts b/src/next/blocks/blockPrettier.test.ts index ef447c7d8..fc9787c9e 100644 --- a/src/next/blocks/blockPrettier.test.ts +++ b/src/next/blocks/blockPrettier.test.ts @@ -100,7 +100,8 @@ describe("blockPrettier", () => { }, ".prettierignore": "/.husky /lib - /pnpm-lock.yaml", + /pnpm-lock.yaml + ", ".prettierrc.json": "{"$schema":"http://json.schemastore.org/prettierrc","useTabs":true}", }, "scripts": [ @@ -211,7 +212,8 @@ describe("blockPrettier", () => { }, ".prettierignore": "/.husky /lib - /pnpm-lock.yaml", + /pnpm-lock.yaml + ", ".prettierrc.json": "{"$schema":"http://json.schemastore.org/prettierrc","useTabs":true}", }, "scripts": [ @@ -340,7 +342,8 @@ describe("blockPrettier", () => { ".prettierignore": "/.husky /lib /pnpm-lock.yaml - generated", + generated + ", ".prettierrc.json": "{"$schema":"http://json.schemastore.org/prettierrc","overrides":[{"files":".nvmrc","options":{"parser":"yaml"}}],"plugins":["prettier-plugin-curly","prettier-plugin-packagejson","prettier-plugin-sh"],"useTabs":true}", }, "scripts": [ diff --git a/src/next/blocks/blockPrettier.ts b/src/next/blocks/blockPrettier.ts index bce284e4c..628a556f6 100644 --- a/src/next/blocks/blockPrettier.ts +++ b/src/next/blocks/blockPrettier.ts @@ -1,5 +1,6 @@ import { z } from "zod"; +import { formatIgnoreFile } from "../../steps/writing/creation/formatters/formatIgnoreFile.js"; import { base } from "../base.js"; import { blockCSpell } from "./blockCSpell.js"; import { blockDevelopmentDocs } from "./blockDevelopmentDocs.js"; @@ -96,9 +97,9 @@ pnpm format --write ".gitignore": "_\n", "pre-commit": ["npx lint-staged\n", { mode: 0x777 }], }, - ".prettierignore": ["/.husky", "/lib", "/pnpm-lock.yaml", ...ignores] - .sort() - .join("\n"), + ".prettierignore": formatIgnoreFile( + ["/.husky", "/lib", "/pnpm-lock.yaml", ...ignores].sort(), + ), ".prettierrc.json": JSON.stringify({ $schema: "http://json.schemastore.org/prettierrc", ...(overrides.length && { overrides: overrides.sort() }),