Skip to content

Artifact download URL when using --deploy=local is wrong #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aviks opened this issue Nov 2, 2022 · 0 comments · May be fixed by #1378
Open

Artifact download URL when using --deploy=local is wrong #1241

aviks opened this issue Nov 2, 2022 · 0 comments · May be fixed by #1378

Comments

@aviks
Copy link

aviks commented Nov 2, 2022

When running build_tarballs.jl with a --deploy=local option, the resulting Artifact.toml has the artifact download url set to something like this: https://github.com/local/releases/download/MyPkg-v0.2.1+1/MyPkg.v0.2.1.aarch64-apple-darwin.tar.gz

Now the right value here is unkown so it's not clear what should happen. Maybe some more affordances to let the user know that this value should be changed? https://github.com/CHANGE/ME/releases/downloads.... . The current value is plausible enough to be dangerous, IMO.

@t-bltg t-bltg linked a pull request Apr 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant