Skip to content

Commit d5b83bd

Browse files
vchuravygiordano
authored andcommitted
Discourage -fomit-frame-pointer
1 parent 5d6d8d6 commit d5b83bd

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/Runner.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ function generate_compiler_wrappers!(platform::AbstractPlatform; bin_path::Abstr
573573

574574
function gcc_unsafe_flags!(p::AbstractPlatform, flags::Vector{String} = String[])
575575
if !allow_unsafe_flags
576-
return String["-Ofast", "-ffast-math", "-funsafe-math-optimizations"]
576+
return String["-Ofast", "-ffast-math", "-funsafe-math-optimizations", "-fomit-frame-pointer"]
577577
end
578578
return String[]
579579
end

test/runners.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ end
418418
@test !run(ur, cmd, iobuff; tee_stream=devnull)
419419
seekstart(iobuff)
420420
lines = readlines(iobuff)
421-
@test lines[2] == "BinaryBuilder: You used one or more of the unsafe flags: -Ofast, -ffast-math, -funsafe-math-optimizations"
421+
@test lines[2] == "BinaryBuilder: You used one or more of the unsafe flags: -Ofast, -ffast-math, -funsafe-math-optimizations, -fomit-frame-pointer"
422422
@test lines[3] == "Please repent."
423423

424424
ur = preferred_runner()(dir; platform=platform, allow_unsafe_flags=true)

0 commit comments

Comments
 (0)