Update build scripts to support Windows (#1120)

* update scripts to support running on windows

* configure prettier to use lf line endings

* force git to checkout lf line endings

* add windows ci workflow

* fix cs-format script

* run prettier on tests

Author: dstaley

Diff for: .gitattributes

@@ -0,0 +1 @@
+* text eol=lf

Diff for: .github/workflows/windows-ci.yml

@@ -0,0 +1,29 @@
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+
+name: Windows Integration
+jobs:
+  chore:
+    name: Testing on Windows
+    runs-on: windows-latest
+
+    steps:
+      - uses: actions/checkout@master
+
+      - name: Print environment
+        run: |
+          node --version
+          npm --version
+          python --version
+          pip --version
+      - name: Install Node dependencies
+        run: npm ci
+
+      - name: Install Python dependencies
+        run: pip install kinto kinto-attachment
+
+      - name: Run tests
+        run: npm test

Diff for: .prettierrc

@@ -1,3 +1,4 @@
 {
-  "trailingComma": "es5"
+  "trailingComma": "es5",
+  "endOfLine": "lf"
 }

Diff for: bin/dist-fx.ts

@@ -0,0 +1,24 @@
+import { mkdir, cp, exec, echo, cat, rm } from "shelljs";
+import { readFileSync } from "fs";
+
+function getVersionFromPackageJson(): string {
+  const pkgJson = readFileSync("package.json", "utf8");
+  const { version } = JSON.parse(pkgJson);
+  return version;
+}
+
+const rollupOutput = "dist/temp.js";
+const destination = "dist/moz-kinto-offline-client.js";
+
+mkdir("-p", "dist");
+
+cp("fx-src/jsm_prefix.js", destination);
+
+const gitRev = exec("git rev-parse --short HEAD", {
+  silent: true,
+}).stdout.trim();
+const version = getVersionFromPackageJson();
+
+echo(`\n/*\n * Version ${version} - ${gitRev}\n */\n`).toEnd(destination);
+cat(rollupOutput).toEnd(destination);
+rm(rollupOutput);

Diff for: package-lock.json

@@ -9,14 +9,14 @@
     "build": "npm run build:es && npm run build:cjs-es5",
     "build:es": "tsc -p .",
     "build:cjs-es5": "tsc -p . --outDir lib/cjs-es5 --module commonjs --target es5",
-    "build-demo": "npm run dist && cp dist/kinto.min.js demo/kinto.min.js && cp dist/kinto.min.js.map demo/kinto.min.js.map",
+    "build-demo": "npm run dist && shx cp dist/kinto.min.js demo/kinto.min.js && shx cp dist/kinto.min.js.map demo/kinto.min.js.map",
     "compute-sri": "version=$(npm view kinto version); printf \"| Filename %-14s | Hash %-66s |\\n\" \"\" \"(for version $version)\"; printf \"|-------------------------|-------------------------------------------------------------------------|\\n\"; cd dist; for file in kinto*.js; do printf \"| %-23s | %-71s |\\n\" ${file} $(echo -n 'sha384-' && curl --silent https://unpkg.com/kinto@$version/dist/${file} | openssl dgst -sha384 -binary | openssl enc -base64); done",
-    "cs-check": "prettier '{src,test}/**/*.js'",
-    "cs-format": "prettier '{src,test}/**/*.js' --write",
+    "cs-check": "prettier -l \"{src,test,bin}/**/*.{js,ts}\"",
+    "cs-format": "prettier \"{src,test,bin}/**/*.{js,ts}\" --write",
     "demo": "npm run build-demo && http-server demo",
-    "dist": "NODE_ENV=production rollup -c && npm run dist:fx",
+    "dist": "cross-env NODE_ENV=production rollup -c && npm run dist:fx",
     "dist:dev": "rollup -c && npm run dist:fx",
-    "dist:fx": "mkdir -p dist && cp fx-src/jsm_prefix.js dist/moz-kinto-offline-client.js && echo \"\n/*\n * Version $npm_package_version - $(git rev-parse --short HEAD)\n */\n\" >> dist/moz-kinto-offline-client.js && cat dist/temp.js >> dist/moz-kinto-offline-client.js && rm dist/temp.js && echo >> dist/moz-kinto-offline-client.js",
+    "dist:fx": "ts-node --skip-project bin/dist-fx.ts",
     "lint": "eslint src test",
     "publish-demo": "npm run dist-prod && cp dist/kinto.js demo/kinto.js && gh-pages -d demo",
     "publish-to-npm": "npm run dist && npm run build && npm publish",
@@ -25,9 +25,8 @@
     "test": "npm run lint && npm run test-nocover",
     "test-cover": "nyc --reporter=lcov --reporter=text-summary --report-dir=coverage npm run test-nocover",
     "test-cover-html": "nyc --reporter=html --report-dir=coverage npm run test-nocover && open coverage/index.html",
-    "test-nocover": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"sourceMap\":true}' mocha -r ts-node/register --require source-map-support/register --full-trace --bail --require ./test/_setup.js 'test/**/*_test.js'"
+    "test-nocover": "cross-env TS_NODE_COMPILER_OPTIONS=\"{\\\"module\\\":\\\"commonjs\\\",\\\"sourceMap\\\":true}\" mocha -r ts-node/register --require source-map-support/register --full-trace --bail --require ./test/_setup.js \"test/**/*_test.{js,ts}\""
   },
-  "prettierOptions": "--trailing-comma es5",
   "repository": {
     "type": "git",
     "url": "https://github.com/Kinto/kinto.js.git"
@@ -140,12 +139,14 @@
     "uuid": "^3.0.0"
   },
   "devDependencies": {
+    "@types/shelljs": "^0.8.6",
     "@typescript-eslint/eslint-plugin": "^2.2.0",
     "@typescript-eslint/parser": "^2.2.0",
     "chai": "^4.0.1",
     "chai-as-promised": "^7.0.0",
     "co-task": "^1.0.0",
     "coveralls": "^3.0.0",
+    "cross-env": "^6.0.3",
     "esdoc": "^1.0.1",
     "esdoc-accessor-plugin": "^1.0.0",
     "esdoc-ecmascript-proposal-plugin": "^1.0.0",
@@ -173,6 +174,8 @@
     "rollup-plugin-node-resolve": "^5.2.0",
     "rollup-plugin-terser": "^5.1.1",
     "rollup-plugin-typescript": "^1.0.1",
+    "shelljs": "^0.8.3",
+    "shx": "^0.3.2",
     "sinon": "^7.2.3",
     "source-map-support": "^0.5.13",
     "ts-node": "^8.3.0",

Diff for: package.json

@@ -396,12 +396,10 @@ describe("adapter.IDB", () => {
 
         describe("multiple values", () => {
           it("should filter the list on a single pre-indexed column", () => {
-            return db
-              .list({ filters: { id: [5, 4] } })
-              .should.eventually.eql([
-                { id: 4, name: "#4" },
-                { id: 5, name: "#5" },
-              ]);
+            return db.list({ filters: { id: [5, 4] } }).should.eventually.eql([
+              { id: 4, name: "#4" },
+              { id: 5, name: "#5" },
+            ]);
           });
 
           it("should filter the list combined with other filters", () => {
@@ -504,15 +502,24 @@ describe("adapter.IDB", () => {
   describe("#importBulk", () => {
     it("should import a list of records.", () => {
       return db
-        .importBulk([{ id: 1, foo: "bar" }, { id: 2, foo: "baz" }])
+        .importBulk([
+          { id: 1, foo: "bar" },
+          { id: 2, foo: "baz" },
+        ])
         .should.eventually.have.length(2);
     });
 
     it("should override existing records.", () => {
       return db
-        .importBulk([{ id: 1, foo: "bar" }, { id: 2, foo: "baz" }])
+        .importBulk([
+          { id: 1, foo: "bar" },
+          { id: 2, foo: "baz" },
+        ])
         .then(() => {
-          return db.importBulk([{ id: 1, foo: "baz" }, { id: 3, foo: "bab" }]);
+          return db.importBulk([
+            { id: 1, foo: "baz" },
+            { id: 3, foo: "bab" },
+          ]);
         })
         .then(() => db.list())
         .should.eventually.eql([

Diff for: test/adapters/IDB_test.js

@@ -419,7 +419,10 @@ describe("Collection", () => {
       it("should deduplicate added entries with same id", () => {
         const result = new SyncResultObject();
 
-        result.add("created", [{ id: 1, name: "a" }, { id: 1, name: "b" }]);
+        result.add("created", [
+          { id: 1, name: "a" },
+          { id: 1, name: "b" },
+        ]);
         expect(result.created).eql([{ id: 1, name: "b" }]);
       });