Skip to content

Extend channel API to have parity with FluxSink #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qwwdfsad opened this issue Mar 14, 2019 · 1 comment
Closed

Extend channel API to have parity with FluxSink #1042

qwwdfsad opened this issue Mar 14, 2019 · 1 comment
Assignees
@qwwdfsad
Labels
enhancement flow

Comments

@qwwdfsad
Copy link
Member

When integrating with blocking API, channel and offer or its variants are used (see also #974). Semantically, it is very similar to FluxSink.

Moreover, in cold streams prototype channels are used to connect with callback-based API.

But at least one important method is missing: isCancelled.
A good example of why it is needed can be found here. Additionally, we may want to include an actual exception.
@qwwdfsad qwwdfsad self-assigned this Mar 14, 2019
@qwwdfsad qwwdfsad changed the title Extend channels API to have parity with FluxSink Extend channel API to have parity with FluxSink Mar 14, 2019
@qwwdfsad qwwdfsad added this to the 1.3.0 milestone Mar 25, 2019
@qwwdfsad qwwdfsad added the flow label Apr 10, 2019
@elizarov elizarov removed this from the 1.3.0-alpha milestone Jul 16, 2019
@qwwdfsad
Copy link
Member Author

qwwdfsad commented Dec 13, 2019 •
edited
Loading

Fixed with channelFlow since 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwwdfsad qwwdfsad

Labels
enhancement flow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elizarov @qwwdfsad