You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
rfc5321: improve error message for bad IDNA domains
Previously, we'd use the default presentation for the Error type
reported by the idna crate. Unfortunately, that type holds no
context: it is a zero-sized empty struct type, and it chooses
to render itself as `Errors`, which isn't super helpful, but
it is hard to convey every possible error clause from the underlying
spec, so I understand why this is this way.
This commit handles that error case to present a slightly more
informative error message.
It doesn't provide context on what specifically is bad about
the input, but it at least helps to characterize that the domain
is bad, rather than imply that we don't know how to deal with
punycode at all.
The specific problem with the domain in the included test
case is most likely BIDI related per discussion in
servo/rust-url#489
0 commit comments