Skip to content

Commit cd30cb8

Browse files
NickalasBKyleFin
authored andcommitted
[webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404)
This is the first-step task to add a zoomEnabled param on the WebView widget.
1 parent 49918c7 commit cd30cb8

File tree

5 files changed

+12
-2
lines changed

5 files changed

+12
-2
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.1.0
2+
3+
* Add `zoomEnabled` functionality to `WebSettings`.
4+
15
## 1.0.0
26

37
* Extracted platform interface from `webview_flutter`.

packages/webview_flutter/webview_flutter_platform_interface/lib/src/method_channel/webview_method_channel.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,7 @@ class MethodChannelWebViewPlatform implements WebViewPlatformController {
200200
_addIfNonNull(
201201
'allowsInlineMediaPlayback', settings.allowsInlineMediaPlayback);
202202
_addSettingIfPresent('userAgent', settings.userAgent);
203+
_addIfNonNull('zoomEnabled', settings.zoomEnabled);
203204
return map;
204205
}
205206

packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/web_settings.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ class WebSettings {
7878
this.debuggingEnabled,
7979
this.gestureNavigationEnabled,
8080
this.allowsInlineMediaPlayback,
81+
this.zoomEnabled,
8182
required this.userAgent,
8283
}) : assert(userAgent != null);
8384

@@ -111,6 +112,9 @@ class WebSettings {
111112
/// See also [WebView.userAgent].
112113
final WebSetting<String?> userAgent;
113114

115+
/// Sets whether the WebView should support zooming using its on-screen zoom controls and gestures.
116+
final bool? zoomEnabled;
117+
114118
/// Whether to allow swipe based navigation in iOS.
115119
///
116120
/// See also: [WebView.gestureNavigationEnabled]

packages/webview_flutter/webview_flutter_platform_interface/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ repository: https://github.com/flutter/plugins/tree/master/packages/webview_flut
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview_flutter%22
55
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
66
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
7-
version: 1.0.0
7+
version: 1.1.0
88

99
environment:
1010
sdk: ">=2.12.0 <3.0.0"

packages/webview_flutter/webview_flutter_platform_interface/test/src/method_channel/webview_method_channel_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import 'package:flutter/services.dart';
66
import 'package:flutter_test/flutter_test.dart';
77
import 'package:mockito/mockito.dart';
8-
98
import 'package:webview_flutter_platform_interface/src/method_channel/webview_method_channel.dart';
109
import 'package:webview_flutter_platform_interface/webview_flutter_platform_interface.dart';
1110

@@ -229,6 +228,7 @@ void main() {
229228
debuggingEnabled: true,
230229
gestureNavigationEnabled: true,
231230
allowsInlineMediaPlayback: true,
231+
zoomEnabled: false,
232232
);
233233
await webViewPlatform.updateSettings(settings);
234234

@@ -245,6 +245,7 @@ void main() {
245245
'debuggingEnabled': true,
246246
'gestureNavigationEnabled': true,
247247
'allowsInlineMediaPlayback': true,
248+
'zoomEnabled': false,
248249
},
249250
),
250251
],

0 commit comments

Comments
 (0)