Skip to content

Commit 6fb7d44

Browse files
committed
Backends: SDL2/SDL3: Comments. (ocornut#7672, ocornut#7670)
1 parent 32cea85 commit 6fb7d44

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

backends/imgui_impl_sdl2.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -399,6 +399,8 @@ bool ImGui_ImplSDL2_ProcessEvent(const SDL_Event* event)
399399
if (ImGui_ImplSDL2_GetViewportForWindowID(event->key.windowID) == nullptr)
400400
return false;
401401
ImGui_ImplSDL2_UpdateKeyModifiers((SDL_Keymod)event->key.keysym.mod);
402+
//IMGUI_DEBUG_LOG("SDL_KEY_%s : key=%d ('%s'), scancode=%d ('%s'), mod=%X\n",
403+
// (event->type == SDL_KEYDOWN) ? "DOWN" : "UP ", event->key.keysym.sym, SDL_GetKeyName(event->key.keysym.sym), event->key.keysym.scancode, SDL_GetScancodeName(event->key.keysym.scancode), event->key.keysym.mod);
402404
ImGuiKey key = ImGui_ImplSDL2_KeyEventToImGuiKey(event->key.keysym.sym, event->key.keysym.scancode);
403405
io.AddKeyEvent(key, (event->type == SDL_KEYDOWN));
404406
io.SetKeyEventNativeData(key, event->key.keysym.sym, event->key.keysym.scancode, event->key.keysym.scancode); // To support legacy indexing (<1.87 user code). Legacy backend uses SDLK_*** as indices to IsKeyXXX() functions.

backends/imgui_impl_sdl3.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -375,8 +375,9 @@ bool ImGui_ImplSDL3_ProcessEvent(const SDL_Event* event)
375375
{
376376
if (ImGui_ImplSDL3_GetViewportForWindowID(event->key.windowID) == nullptr)
377377
return false;
378-
//IMGUI_DEBUG_LOG("SDL_EVENT_KEY_%d: key=%d, scancode=%d, mod=%X\n", (event->type == SDL_EVENT_KEY_DOWN) ? "DOWN" : "UP", event->key.key, event->key.scancode, event->key.mod);
379378
ImGui_ImplSDL3_UpdateKeyModifiers((SDL_Keymod)event->key.mod);
379+
//IMGUI_DEBUG_LOG("SDL_EVENT_KEY_%s : key=%d ('%s'), scancode=%d ('%s'), mod=%X\n",
380+
// (event->type == SDL_EVENT_KEY_DOWN) ? "DOWN" : "UP ", event->key.key, SDL_GetKeyName(event->key.key), event->key.scancode, SDL_GetScancodeName(event->key.scancode), event->key.mod);
380381
ImGuiKey key = ImGui_ImplSDL3_KeyEventToImGuiKey(event->key.key, event->key.scancode);
381382
io.AddKeyEvent(key, (event->type == SDL_EVENT_KEY_DOWN));
382383
io.SetKeyEventNativeData(key, event->key.key, event->key.scancode, event->key.scancode); // To support legacy indexing (<1.87 user code). Legacy backend uses SDLK_*** as indices to IsKeyXXX() functions.

imgui_demo.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -743,6 +743,7 @@ static void ShowDemoWindowMenuBar(ImGuiDemoWindowData* demo_data)
743743
#else
744744
const bool has_debug_tools = false;
745745
#endif
746+
ImGui::MenuItem("Metrics/Debugger", NULL, &demo_data->ShowMetrics, has_debug_tools);
746747
if (ImGui::BeginMenu("Debug Options"))
747748
{
748749
ImGui::BeginDisabled(!has_debug_tools);
@@ -752,8 +753,6 @@ static void ShowDemoWindowMenuBar(ImGuiDemoWindowData* demo_data)
752753
ImGui::TextDisabled("(see Demo->Configuration for details & more)");
753754
ImGui::EndMenu();
754755
}
755-
756-
ImGui::MenuItem("Metrics/Debugger", NULL, &demo_data->ShowMetrics, has_debug_tools);
757756
ImGui::MenuItem("Debug Log", NULL, &demo_data->ShowDebugLog, has_debug_tools);
758757
ImGui::MenuItem("ID Stack Tool", NULL, &demo_data->ShowIDStackTool, has_debug_tools);
759758
bool is_debugger_present = io.ConfigDebugIsDebuggerPresent;

0 commit comments

Comments
 (0)