store: drop requirements_file_path (#16527)

Author: Borda

src/lightning/store/cloud_api.py

@@ -36,7 +36,6 @@
     _save_model,
     _save_model_code,
     _save_model_weights,
-    _save_requirements_file,
     _submit_data_to_url,
     _write_and_save_requirements,
 )
@@ -51,7 +50,6 @@ def upload_to_cloud(
     model=None,
     source_code_path: str = "",
     checkpoint_path: str = "",
-    requirements_file_path: str = "",
     requirements: Optional[List[str]] = None,
     weights_only: bool = False,
     api_key: str = "",
@@ -77,12 +75,9 @@ def upload_to_cloud(
                 will raise an error. (Optional)
         checkpoint_path:
             The path to the checkpoint that needs to be uploaded. (Optional)
-        requirements_file_path:
-            The path to the requirements file, will always be uploaded with the name of `requirements.txt`.
         requirements:
             List of requirements as strings, that will be written as `requirements.txt` and
-                then uploaded. If both `requirements_file_path` and `requirements` are passed,
-                a warning is raised as `requirements` is given the priority over `requirements_file_path`.
+                then uploaded.
         weights_only:
             If set to `True`, it will only save model weights and nothing else. This raises
                 an error if `weights_only` is `True` but no `model` is passed.
@@ -146,28 +141,13 @@ def upload_to_cloud(
                         stored=stored,
                     )
 
-        if requirements and requirements_file_path:
-            # TODO: Later on, figure out how to merge requirements from both args
-            logging.warning(
-                "You provided a requirements file (..., requirements_file_path=...)"
-                " and requirements list (..., requirements=...). In case of any collisions,"
-                " anything that comes from requirements=... will be given the priority."
-            )
-
         if requirements:
             stored = _write_and_save_requirements(
                 model_name,
                 requirements=requirements,
                 stored=stored,
                 tmpdir=tmpdir,
             )
-        elif requirements_file_path:
-            stored = _save_requirements_file(
-                model_name,
-                requirements_file_path=requirements_file_path,
-                stored=stored,
-                tmpdir=tmpdir,
-            )
 
         url = _save_meta_data(
             model_name,

tests/tests_cloud/test_requirements.py

@@ -1,35 +1,14 @@
 import os
 
-from tests_cloud import _API_KEY, _PROJECT_ID, _PROJECT_ROOT, _USERNAME
+from tests_cloud import _API_KEY, _PROJECT_ID, _USERNAME
 from tests_cloud.helpers import cleanup
 
 from lightning.store import download_from_cloud, upload_to_cloud
 from lightning.store.save import _LIGHTNING_STORAGE_DIR
 from pytorch_lightning.demos.boring_classes import BoringModel
 
 
-def test_requirements_as_a_file(version: str = "latest", model_name: str = "boring_model"):
-    cleanup()
-
-    requirements_file_path = os.path.join(_PROJECT_ROOT, "requirements", "app", "base.txt")
-
-    upload_to_cloud(
-        model_name,
-        version=version,
-        model=BoringModel(),
-        requirements_file_path=requirements_file_path,
-        api_key=_API_KEY,
-        project_id=_PROJECT_ID,
-    )
-
-    download_from_cloud(f"{_USERNAME}/{model_name}")
-
-    req_folder_path = os.path.join(_LIGHTNING_STORAGE_DIR, _USERNAME, model_name, version)
-    assert os.path.isdir(req_folder_path), "missing: %s" % req_folder_path
-    assert "requirements.txt" in os.listdir(req_folder_path), "among files: %r" % os.listdir(req_folder_path)
-
-
-def test_requirements_as_a_list(version: str = "1.0.0", model_name: str = "boring_model"):
+def test_requirements(version: str = "1.0.0", model_name: str = "boring_model"):
     cleanup()
 
     requirements_list = ["pytorch_lightning==1.7.7", "lightning"]