Skip to content

Commit 606af08

Browse files
committed
register_hook
1 parent 2032602 commit 606af08

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

pytorch_lightning/loops/epoch/training_epoch_loop.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,8 @@ def _update_learning_rates(
505505
self.scheduler_progress.increment_ready()
506506

507507
# update LR
508-
self.trainer.lightning_module.lr_scheduler_step(
508+
self.trainer._call_lightning_module_hook(
509+
"lr_scheduler_step",
509510
lr_scheduler["scheduler"],
510511
optimizer_idx=lr_scheduler["opt_idx"],
511512
monitor_val=monitor_val,

pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ class _LogOptions(TypedDict):
4343
"optimizer_step": _LogOptions(
4444
allowed_on_step=(False, True), allowed_on_epoch=(False, True), default_on_step=True, default_on_epoch=False
4545
),
46+
"lr_scheduler_step": None,
4647
"on_before_zero_grad": _LogOptions(
4748
allowed_on_step=(False, True), allowed_on_epoch=(False, True), default_on_step=True, default_on_epoch=False
4849
),

tests/trainer/logging_/test_logger_connector.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@ def test_fx_validator_integration(tmpdir):
233233
"configure_callbacks": "You can't",
234234
"on_validation_model_eval": "You can't",
235235
"on_validation_model_train": "You can't",
236+
"lr_scheduler_step": "You can't",
236237
"summarize": "not managed by the `Trainer",
237238
}
238239
model = HookedModel(not_supported)

0 commit comments

Comments
 (0)