Simplify hanging queue test (#10591)

Author: carmocca

.github/workflows/ci_test-base.yml

@@ -20,7 +20,7 @@ jobs:
         # this will install stable torch
         python-version: [3.9]
 
-    # Timeout: https://stackoverflow.com/a/59076067/4521646
+    # lower timeout as this should run very quickly
     timeout-minutes: 20
     steps:
     - uses: actions/checkout@v2

.github/workflows/ci_test-conda.yml

@@ -17,7 +17,6 @@ jobs:
         python-version: ["3.8"]  # previous to last Python version as that one is already used in test-full
         pytorch-version: ["1.6", "1.7", "1.8", "1.9", "1.10"]
 
-    # Timeout: https://stackoverflow.com/a/59076067/4521646
     timeout-minutes: 35
     steps:
     - uses: actions/checkout@v2

.github/workflows/ci_test-full.yml

@@ -34,8 +34,6 @@ jobs:
           - {os: windows-2019, python-version: "3.9", requires: "oldest", release: "stable"}
           - {os: macOS-10.15, python-version: "3.9", requires: "oldest", release: "stable"}
 
-    # Timeout: https://stackoverflow.com/a/59076067/4521646
-    # TODO: the macOS is taking too long, probably caching did not work...
     timeout-minutes: 40
 
     steps:

tests/deprecated_api/test_remove_1-7.py

@@ -15,7 +15,6 @@
 from unittest import mock
 
 import pytest
-import torch
 
 from pytorch_lightning import Callback, LightningDataModule, Trainer
 from pytorch_lightning.callbacks.gpu_stats_monitor import GPUStatsMonitor
@@ -230,22 +229,16 @@ def test_v1_7_0_flush_logs_every_n_steps_trainer_constructor(tmpdir):
 
 
 class BoringCallbackDDPSpawnModel(BoringModel):
-    def __init__(self):
-        super().__init__()
+    def add_to_queue(self, queue):
+        ...
 
-    def add_to_queue(self, queue: torch.multiprocessing.SimpleQueue) -> None:
-        queue.put("test_val")
-        return super().add_to_queue(queue)
+    def get_from_queue(self, queue):
+        ...
 
-    def get_from_queue(self, queue: torch.multiprocessing.SimpleQueue) -> None:
-        self.test_val = queue.get()
-        return super().get_from_queue(queue)
 
-
-@RunIf(skip_windows=True, skip_49370=True)
 def test_v1_7_0_deprecate_add_get_queue(tmpdir):
     model = BoringCallbackDDPSpawnModel()
-    trainer = Trainer(default_root_dir=tmpdir, fast_dev_run=True, num_processes=2, strategy="ddp_spawn")
+    trainer = Trainer(default_root_dir=tmpdir, fast_dev_run=True)
 
     with pytest.deprecated_call(match=r"`LightningModule.add_to_queue` method was deprecated in v1.5"):
         trainer.fit(model)