Skip to content

Commit b57fecc

Browse files
authored
Be explicit with mypy ignores (#10751)
* Ignore mypy only for failing files * Comment
1 parent 85d7c4d commit b57fecc

File tree

1 file changed

+102
-36
lines changed

1 file changed

+102
-36
lines changed

pyproject.toml

Lines changed: 102 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -37,43 +37,109 @@ disable_error_code = "attr-defined"
3737
warn_no_return = "False"
3838

3939
# Changes mypy default to ignore all errors
40+
# TODO: the goal is for this to be empty
4041
[[tool.mypy.overrides]]
42+
# the list can be generated with:
43+
# mypy | tr ':' ' ' | awk '{print $1}' | sort | uniq | sed 's/\.py//g' | sed 's|\/|\.|g' | xargs -I {} echo '"{}",'
4144
module = [
42-
"pytorch_lightning.*",
45+
"pytorch_lightning.accelerators.accelerator",
46+
"pytorch_lightning.accelerators.gpu",
47+
"pytorch_lightning.callbacks.finetuning",
48+
"pytorch_lightning.callbacks.lr_monitor",
49+
"pytorch_lightning.callbacks.model_checkpoint",
50+
"pytorch_lightning.callbacks.prediction_writer",
51+
"pytorch_lightning.callbacks.progress.base",
52+
"pytorch_lightning.callbacks.progress.progress",
53+
"pytorch_lightning.callbacks.progress.rich_progress",
54+
"pytorch_lightning.callbacks.progress.tqdm_progress",
55+
"pytorch_lightning.callbacks.quantization",
56+
"pytorch_lightning.callbacks.stochastic_weight_avg",
57+
"pytorch_lightning.callbacks.timer",
58+
"pytorch_lightning.callbacks.xla_stats_monitor",
59+
"pytorch_lightning.core.datamodule",
60+
"pytorch_lightning.core.decorators",
61+
"pytorch_lightning.core.lightning",
62+
"pytorch_lightning.core.mixins.device_dtype_mixin",
63+
"pytorch_lightning.core.mixins.hparams_mixin",
64+
"pytorch_lightning.core.saving",
65+
"pytorch_lightning.distributed.dist",
66+
"pytorch_lightning.lite.lite",
67+
"pytorch_lightning.lite.wrappers",
68+
"pytorch_lightning.loggers.base",
69+
"pytorch_lightning.loggers.comet",
70+
"pytorch_lightning.loggers.csv_logs",
71+
"pytorch_lightning.loggers.mlflow",
72+
"pytorch_lightning.loggers.neptune",
73+
"pytorch_lightning.loggers.tensorboard",
74+
"pytorch_lightning.loggers.test_tube",
75+
"pytorch_lightning.loggers.wandb",
76+
"pytorch_lightning.loops.base",
77+
"pytorch_lightning.loops.batch.training_batch_loop",
78+
"pytorch_lightning.loops.dataloader.dataloader_loop",
79+
"pytorch_lightning.loops.dataloader.evaluation_loop",
80+
"pytorch_lightning.loops.dataloader.prediction_loop",
81+
"pytorch_lightning.loops.epoch.evaluation_epoch_loop",
82+
"pytorch_lightning.loops.epoch.prediction_epoch_loop",
83+
"pytorch_lightning.loops.epoch.training_epoch_loop",
84+
"pytorch_lightning.loops.fit_loop",
85+
"pytorch_lightning.loops.optimization.optimizer_loop",
86+
"pytorch_lightning.loops.utilities",
87+
"pytorch_lightning.overrides.base",
88+
"pytorch_lightning.overrides.data_parallel",
89+
"pytorch_lightning.overrides.distributed",
90+
"pytorch_lightning.overrides.fairscale",
91+
"pytorch_lightning.plugins.environments.lightning_environment",
92+
"pytorch_lightning.plugins.environments.lsf_environment",
93+
"pytorch_lightning.plugins.environments.slurm_environment",
94+
"pytorch_lightning.plugins.environments.torchelastic_environment",
95+
"pytorch_lightning.plugins.precision.deepspeed",
96+
"pytorch_lightning.plugins.precision.native_amp",
97+
"pytorch_lightning.plugins.precision.precision_plugin",
98+
"pytorch_lightning.plugins.training_type.ddp",
99+
"pytorch_lightning.plugins.training_type.ddp2",
100+
"pytorch_lightning.plugins.training_type.ddp_spawn",
101+
"pytorch_lightning.plugins.training_type.deepspeed",
102+
"pytorch_lightning.plugins.training_type.dp",
103+
"pytorch_lightning.plugins.training_type.fully_sharded",
104+
"pytorch_lightning.plugins.training_type.horovod",
105+
"pytorch_lightning.plugins.training_type.ipu",
106+
"pytorch_lightning.plugins.training_type.parallel",
107+
"pytorch_lightning.plugins.training_type.sharded",
108+
"pytorch_lightning.plugins.training_type.sharded_spawn",
109+
"pytorch_lightning.plugins.training_type.single_device",
110+
"pytorch_lightning.plugins.training_type.single_tpu",
111+
"pytorch_lightning.plugins.training_type.tpu_spawn",
112+
"pytorch_lightning.plugins.training_type.training_type_plugin",
113+
"pytorch_lightning.profiler.advanced",
114+
"pytorch_lightning.profiler.base",
115+
"pytorch_lightning.profiler.pytorch",
116+
"pytorch_lightning.profiler.simple",
117+
"pytorch_lightning.trainer.callback_hook",
118+
"pytorch_lightning.trainer.configuration_validator",
119+
"pytorch_lightning.trainer.connectors.accelerator_connector",
120+
"pytorch_lightning.trainer.connectors.callback_connector",
121+
"pytorch_lightning.trainer.connectors.checkpoint_connector",
122+
"pytorch_lightning.trainer.connectors.data_connector",
123+
"pytorch_lightning.trainer.connectors.logger_connector.result",
124+
"pytorch_lightning.trainer.data_loading",
125+
"pytorch_lightning.trainer.optimizers",
126+
"pytorch_lightning.trainer.supporters",
127+
"pytorch_lightning.trainer.trainer",
128+
"pytorch_lightning.tuner.batch_size_scaling",
129+
"pytorch_lightning.tuner.lr_finder",
130+
"pytorch_lightning.tuner.tuning",
131+
"pytorch_lightning.utilities.auto_restart",
132+
"pytorch_lightning.utilities.data",
133+
"pytorch_lightning.utilities.deepspeed",
134+
"pytorch_lightning.utilities.distributed",
135+
"pytorch_lightning.utilities.enums",
136+
"pytorch_lightning.utilities.fetching",
137+
"pytorch_lightning.utilities.imports",
138+
"pytorch_lightning.utilities.memory",
139+
"pytorch_lightning.utilities.meta",
140+
"pytorch_lightning.utilities.metrics",
141+
"pytorch_lightning.utilities.migration",
142+
"pytorch_lightning.utilities.upgrade_checkpoint",
143+
"pytorch_lightning.utilities.warnings",
43144
]
44145
ignore_errors = "True"
45-
46-
# Override the default for files where we would like to enable type checking
47-
# TODO: Bring more files into this section
48-
[[tool.mypy.overrides]]
49-
module = [
50-
"pytorch_lightning.callbacks.device_stats_monitor",
51-
"pytorch_lightning.callbacks.early_stopping",
52-
"pytorch_lightning.callbacks.gpu_stats_monitor",
53-
"pytorch_lightning.callbacks.gradient_accumulation_scheduler",
54-
"pytorch_lightning.callbacks.model_summary",
55-
"pytorch_lightning.callbacks.progress",
56-
"pytorch_lightning.callbacks.pruning",
57-
"pytorch_lightning.callbacks.rich_model_summary",
58-
"pytorch_lightning.core.optimizer",
59-
"pytorch_lightning.loops.optimization.closure.py",
60-
"pytorch_lightning.loops.optimization.manual_loop.py",
61-
"pytorch_lightning.loops.evaluation_loop",
62-
"pytorch_lightning.trainer.connectors.logger_connector.py",
63-
"pytorch_lightning.trainer.connectors.logger_connector.fx_validator.py",
64-
"pytorch_lightning.trainer.connectors.signal_connector",
65-
"pytorch_lightning.trainer.progress.*",
66-
"pytorch_lightning.tuner.auto_gpu_select",
67-
"pytorch_lightning.utilities.apply_func",
68-
"pytorch_lightning.utilities.argparse",
69-
"pytorch_lightning.utilities.cli",
70-
"pytorch_lightning.utilities.cloud_io",
71-
"pytorch_lightning.utilities.device_dtype_mixin",
72-
"pytorch_lightning.utilities.device_parser",
73-
"pytorch_lightning.utilities.model_summary",
74-
"pytorch_lightning.utilities.parameter_tying",
75-
"pytorch_lightning.utilities.parsing",
76-
"pytorch_lightning.utilities.seed",
77-
"pytorch_lightning.utilities.xla_device",
78-
]
79-
ignore_errors = "False"

0 commit comments

Comments
 (0)