Skip to content

Commit bc191af

Browse files
committed
tests deprecation message
1 parent 78a5a92 commit bc191af

File tree

4 files changed

+16
-6
lines changed

4 files changed

+16
-6
lines changed

tests/callbacks/test_gpu_stats_monitor.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ def test_gpu_stats_monitor(tmpdir):
4747
logger=logger,
4848
)
4949

50-
with pytest.deprecated_call(match="`Trainer.data_parallel_device_ids` was deprecated in v1.6."):
50+
with pytest.deprecated_call(
51+
match="Trainer.data_parallel_device_ids` was deprecated in v1.6 and will be removed in v1.8."
52+
):
5153
trainer.fit(model)
5254
assert trainer.state.finished, f"Training failed with {trainer.state}"
5355

@@ -87,7 +89,9 @@ def test_gpu_stats_monitor_no_queries(tmpdir):
8789
)
8890
with mock.patch(
8991
"pytorch_lightning.loggers.tensorboard.TensorBoardLogger.log_metrics"
90-
) as log_metrics_mock, pytest.deprecated_call(match="`Trainer.data_parallel_device_ids` was deprecated in v1.6."):
92+
) as log_metrics_mock, pytest.deprecated_call(
93+
match="Trainer.data_parallel_device_ids` was deprecated in v1.6 and will be removed in v1.8."
94+
):
9195
trainer.fit(model)
9296

9397
assert log_metrics_mock.mock_calls[1:] == [

tests/models/test_gpu.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,10 +245,12 @@ def test_torchelastic_gpu_parsing(mocked_device_count, mocked_is_available, gpus
245245
assert isinstance(trainer._accelerator_connector.cluster_environment, TorchElasticEnvironment)
246246
assert trainer.gpus == gpus
247247
if rank_zero_only.rank == 0:
248-
with pytest.deprecated_call(match="`Trainer.data_parallel_device_ids` was deprecated in v1.6."):
248+
with pytest.deprecated_call(
249+
match="Trainer.data_parallel_device_ids` was deprecated in v1.6 and will be removed in v1.8."
250+
):
249251
assert (trainer.data_parallel_device_ids or None) == device_parser.parse_gpu_ids(gpus)
250252
else:
251-
assert trainer.data_parallel_device_ids == device_parser.parse_gpu_ids(gpus)
253+
assert (trainer.data_parallel_device_ids or None) == device_parser.parse_gpu_ids(gpus)
252254

253255

254256
@RunIf(min_gpus=1)

tests/trainer/test_trainer_cli.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,9 @@ def test_argparse_args_parsing_devices(cli_args, expected_parsed, expected_devic
176176

177177
assert args.devices == expected_parsed
178178
trainer = Trainer.from_argparse_args(args)
179-
with pytest.deprecated_call(match="`Trainer.data_parallel_device_ids` was deprecated in v1.6."):
179+
with pytest.deprecated_call(
180+
match="Trainer.data_parallel_device_ids` was deprecated in v1.6 and will be removed in v1.8."
181+
):
180182
assert trainer.data_parallel_device_ids == expected_device_ids
181183

182184

tests/utilities/test_cli.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,9 @@ def test_parse_args_parsing_gpus(monkeypatch, cli_args, expected_gpu):
192192
args = parser.parse_args()
193193

194194
trainer = Trainer.from_argparse_args(args)
195-
with pytest.deprecated_call(match="`Trainer.data_parallel_device_ids` was deprecated in v1.6."):
195+
with pytest.deprecated_call(
196+
match="Trainer.data_parallel_device_ids` was deprecated in v1.6 and will be removed in v1.8."
197+
):
196198
assert trainer.data_parallel_device_ids == expected_gpu
197199

198200

0 commit comments

Comments
 (0)