Remove the deprecated device_stats_monitor_prefix_keys (#14890)

* Remove the deprecated device_stats_monitor_prefix_keys

* Added pr no to changelog.md

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: otaj <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>

Author: 5 people

src/pytorch_lightning/CHANGELOG.md

@@ -274,10 +274,16 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 - Removed the deprecated `Trainer.call_hook` in favor of `Trainer._call_callback_hooks`, `Trainer._call_lightning_module_hook`, `Trainer._call_ttp_hook`, and `Trainer._call_accelerator_hook` ([#14869](https://github.com/Lightning-AI/lightning/pull/14869))
 
+
 - Removed the deprecated `Trainer.{validated,tested,predicted}_ckpt_path` ([#14897](https://github.com/Lightning-AI/lightning/pull/14897))
 
+
+- Removed the deprecated `device_stats_monitor_prefix_metric_keys` ([#14890](https://github.com/Lightning-AI/lightning/pull/14890))
+
+
 - Removed the deprecated `LightningDataModule.on_save/load_checkpoint` hooks ([#14909](https://github.com/Lightning-AI/lightning/pull/14909))
 
+
 ### Fixed
 
 - Fixed an issue with `LightningLite.setup()` not setting the `.device` attribute correctly on the returned wrapper ([#14822](https://github.com/Lightning-AI/lightning/pull/14822))

src/pytorch_lightning/callbacks/device_stats_monitor.py

@@ -24,7 +24,7 @@
 from pytorch_lightning.callbacks.callback import Callback
 from pytorch_lightning.utilities.exceptions import MisconfigurationException
 from pytorch_lightning.utilities.imports import _PSUTIL_AVAILABLE
-from pytorch_lightning.utilities.rank_zero import rank_zero_deprecation, rank_zero_warn
+from pytorch_lightning.utilities.rank_zero import rank_zero_warn
 from pytorch_lightning.utilities.types import STEP_OUTPUT
 
 
@@ -112,12 +112,3 @@ def on_train_batch_end(
 
 def _prefix_metric_keys(metrics_dict: Dict[str, float], prefix: str, separator: str) -> Dict[str, float]:
     return {prefix + separator + k: v for k, v in metrics_dict.items()}
-
-
-def prefix_metric_keys(metrics_dict: Dict[str, float], prefix: str) -> Dict[str, float]:
-    rank_zero_deprecation(
-        "`pytorch_lightning.callbacks.device_stats_monitor.prefix_metrics`"
-        " is deprecated in v1.6 and will be removed in v1.8."
-    )
-    sep = ""
-    return _prefix_metric_keys(metrics_dict, prefix, sep)

tests/tests_pytorch/deprecated_api/test_remove_1-8.py

@@ -21,13 +21,6 @@
 from pytorch_lightning.demos.boring_classes import BoringModel
 
 
-def test_v_1_8_0_deprecated_device_stats_monitor_prefix_metric_keys():
-    from pytorch_lightning.callbacks.device_stats_monitor import prefix_metric_keys
-
-    with pytest.deprecated_call(match="in v1.6 and will be removed in v1.8"):
-        prefix_metric_keys({"foo": 1.0}, "bar")
-
-
 def test_v1_8_0_remove_on_batch_start_end(tmpdir):
     class TestCallback(Callback):
         def on_batch_start(self, *args, **kwargs):