todo: improve LrSchedulerType naming/typing

jjenniferdai · jjenniferdai · commit c8499dd6012a · 2021-09-14T15:45:33.000-07:00
diff --git a/pytorch_lightning/utilities/types.py b/pytorch_lightning/utilities/types.py
@@ -43,6 +43,7 @@
     Dict[str, Sequence[DataLoader]],
 ]
 EVAL_DATALOADERS = Union[DataLoader, Sequence[DataLoader]]
+# todo: improve LRSchedulerType naming/typing
 LRSchedulerTypeTuple = (_LRScheduler, ReduceLROnPlateau)
 LRSchedulerTypeUnion = Union[_LRScheduler, ReduceLROnPlateau]
 LRSchedulerType = Union[Type[_LRScheduler], Type[ReduceLROnPlateau]]

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@`
`43`	`43`	`Dict[str, Sequence[DataLoader]],`
`44`	`44`	`]`
`45`	`45`	`EVAL_DATALOADERS = Union[DataLoader, Sequence[DataLoader]]`
	`46`	`+# todo: improve LRSchedulerType naming/typing`
`46`	`47`	`LRSchedulerTypeTuple = (_LRScheduler, ReduceLROnPlateau)`
`47`	`48`	`LRSchedulerTypeUnion = Union[_LRScheduler, ReduceLROnPlateau]`
`48`	`49`	`LRSchedulerType = Union[Type[_LRScheduler], Type[ReduceLROnPlateau]]`